577076 - Some chrome images are not loading properly (XUL scrollbars, profile manager icons, Fennec icons)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chwiej Pawel]

User-Agent:       Opera/9.80 (Windows NT 5.1; U; pl) Presto/2.6.30 Version/10.60
Build Identifier: Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b2pre)   Gecko/20100705 Namoroka/4.0b2pre Fennec/2.0a1pre

Maemo5
Gecko/20100705


Reproducible: Always

Steps to Reproduce:
1. Open any page
2. Open tabs strip

Actual Results:  
'New tab' button is missing


Expected Results:  
'New tab' button should be visible at the bottom-left

Comment 2

[Matt Brubeck (:mbrubeck)]

I can reproduce this on Android and desktop Linux too.  After some investigation, it looks like the images for both the newtab and remotetabs buttons are failing to load at startup, but other images do appear correctly (like the non-disabled remotetabs-button image, or the :active image for the newtab-button).

Maybe the chrome: URIs are not yet working for some reason when these buttons first load?  The image does appear in the browser when I enter its chrome: URI in the urlbar.

Comment 3

[Matt Brubeck (:mbrubeck)]

Looks like something in mozilla-central caused this regression.  A randomly-chosen revision pushed on July 2 does not have bug:
http://hg.mozilla.org/mozilla-central/rev/d1be3b90c8d4

but the nightly build from July 3 does have the bug.

Comment 4

[Matt Brubeck (:mbrubeck)]

It looks like this change from Bug 576540 is the culprit:
http://hg.mozilla.org/mozilla-central/rev/f9e9f951c0ab

Comment 6

[Benjamin Smedberg]

Attachment: Fix nsContentUtils::LoadImage

Whoops. I added the extra space to avoid re-indenting, but I can reindent on checkin if you want.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 456477 [details] [diff] [review]
Fix nsContentUtils::LoadImage

Yeah, just reindent on checkin, please.

Comment 8

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/2acaeec7604f

Comment 11

[Alfred Kayser]

Thanks for the fix!