Closed Bug 577076 Opened 14 years ago Closed 14 years ago

Some chrome images are not loading properly (XUL scrollbars, profile manager icons, Fennec icons)

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: p.chwiej, Assigned: benjamin)

References

Details

Attachments

(1 file)

Fix nsContentUtils::LoadImage
1.95 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
User-Agent:       Opera/9.80 (Windows NT 5.1; U; pl) Presto/2.6.30 Version/10.60
Build Identifier: Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:2.0b2pre)   Gecko/20100705 Namoroka/4.0b2pre Fennec/2.0a1pre

Maemo5
Gecko/20100705


Reproducible: Always

Steps to Reproduce:
1. Open any page
2. Open tabs strip

Actual Results:  
'New tab' button is missing


Expected Results:  
'New tab' button should be visible at the bottom-left
Status: UNCONFIRMED → NEW
Ever confirmed: true
I can reproduce this on Android and desktop Linux too.  After some investigation, it looks like the images for both the newtab and remotetabs buttons are failing to load at startup, but other images do appear correctly (like the non-disabled remotetabs-button image, or the :active image for the newtab-button).

Maybe the chrome: URIs are not yet working for some reason when these buttons first load?  The image does appear in the browser when I enter its chrome: URI in the urlbar.
OS: Linux → All
Hardware: Other → All
Looks like something in mozilla-central caused this regression.  A randomly-chosen revision pushed on July 2 does not have bug:
http://hg.mozilla.org/mozilla-central/rev/d1be3b90c8d4

but the nightly build from July 3 does have the bug.
It looks like this change from Bug 576540 is the culprit:
http://hg.mozilla.org/mozilla-central/rev/f9e9f951c0ab
Blocks: 576540
Summary: 'New tab' button is missing → Some chrome images are not loading in Fennec
Whoops. I added the extra space to avoid re-indenting, but I can reindent on checkin if you want.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #456477 - Flags: review?(bzbarsky)
Comment on attachment 456477 [details] [diff] [review]
Fix nsContentUtils::LoadImage

Yeah, just reindent on checkin, please.
Attachment #456477 - Flags: review?(bzbarsky) → review+
Component: General → Graphics
Product: Fennec → Core
QA Contact: general → thebes
blocking2.0: --- → ?
Summary: Some chrome images are not loading in Fennec → Some chrome images are not loading properly (XUL scrollbars, profile manager icons, Fennec icons)
Component: Graphics → DOM
QA Contact: thebes → general
http://hg.mozilla.org/mozilla-central/rev/2acaeec7604f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Thanks for the fix!
Status: RESOLVED → VERIFIED
blocking2.0: ? → final+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: