Closed Bug 577544 Opened 13 years ago Closed 13 years ago

Remove the punycode host correction code in the keychain

Categories

(Camino Graveyard :: OS Integration, defect)

Product:
Camino Graveyard
Component:
OS Integration
Version:
1.9.2 Branch
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

Attachments

(1 file)

removal
10.38 KB, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
KeychainAutoCompleteSession.mm and KeychainService.mm have code to correct for the fact that we used to not use the ASCII (punycode) host, doing two searches and rewriting anything that used the old host. That went out in 1.6; 1.6 and 2.0 is long enough that we should go ahead and pull the code back out for 2.1. If someone hasn't *used* a password since 1.5, I'm okay with it no longer being found.
Assignee: nobody → stuart.morgan+bugzilla
Attached patch removal — — Splinter Review 
This did end up being tangled with the fix for bug 577535, so this includes that; this will be the only patch for 2.1, and bug 577535's patch will just be for 2.0.
Attachment #456522 - Flags: superreview?(mikepinkerton)
Comment on attachment 456522 [details] [diff] [review]
removal

a little hard to disambiguate from the other patch, but *shrug*

sr=pink
Attachment #456522 - Flags: superreview?(mikepinkerton) → superreview+
Pushed http://hg.mozilla.org/camino/rev/e47c84bb4145 for Stuart.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: Trunk → 1.9.2 Branch
You need to log in before you can comment on or make changes to this bug.