Closed Bug 577765 Opened 15 years ago Closed 15 years ago

Positional Parameters in XMLRPC only accepts the first param.

Categories

(Bugzilla :: WebService, defect)

3.5.2
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: gregaryh, Assigned: mkanat)

Details

Attachments

(2 files)

Bug 577415 allowed positional parameters, but only the first one will be accepted. The others are silently ignored.
I take it that there are a fair number of Testopia functions that require multiple positional parameters? This might be more difficult to fix than the other bug was.
(In reply to comment #1) > I take it that there are a fair number of Testopia functions that require > multiple positional parameters? There are a few, but they are rather big (like updating cases, runs, plans etc). > This might be more difficult to fix than the other bug was. I figured as much.
Attached patch v2Splinter Review
How's this? We won't have to maintain this forever--RPC::Any will Just Work, here.
Attachment #456995 - Flags: review?(ghendricks)
Flags: blocking3.6.2+
Target Milestone: --- → Bugzilla 3.6
OS: Linux → All
Hardware: x86 → All
Comment on attachment 456995 [details] [diff] [review] v2 This appears to work. Thank you! :D
Attachment #456995 - Flags: review?(ghendricks) → review+
Flags: approval?
Flags: approval?
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/WebService/Util.pm modified Bugzilla/WebService/Server/XMLRPC.pm Committed revision 7355. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified Bugzilla/WebService/Util.pm modified Bugzilla/WebService/Server/XMLRPC.pm Committed revision 7322. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified Bugzilla/WebService/Util.pm modified Bugzilla/WebService/Server/XMLRPC.pm Committed revision 7136.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This is causing the 3.6 QA boxes to burn: Can't use string ("ids") as a HASH ref while "strict refs" in use at Bugzilla/WebService/Util.pm line 87.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Fix, v1Splinter Review
This fixes the Tinderbox bustage, so I'm going to go ahead and check it in as a sort of "checkin fix".
Attachment #457239 - Flags: review+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/WebService/Util.pm Committed revision 7360. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified Bugzilla/WebService/Util.pm Committed revision 7325. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified Bugzilla/WebService/Util.pm Committed revision 7138.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: