We have no reftest coverage for WebM right now, and we need it.
How these would be different from the ogg reftests ? Could this be achieved using a few sed and ffmpeg invocations ?
WebM reftests would test the WebM decoder backend. You should be able to just convert the Ogg files used by the ogg reftests to WebM using ffmpeg, and create new tests for them identical to the existing Ogg reftests.
Created attachment 547684 [details] [diff] [review] Patch v0 - convertion from OGG testsuite It appears that offset-1.xhtml fails with the webm backend. It is related to video cropping, and I don't know if this is supported in the webm format, since all my video players and browsers don't crop the video (as they do using the ogg version of the file). I've consequently removed that test in this patch, which is basically a |sed -i 's/\(.*\)ogv/\1webm/g' *html| invocation followed by a couple of ffmpeg call.
(In reply to comment #3) > It appears that offset-1.xhtml fails with the webm backend. It is related to > video cropping, and I don't know if this is supported in the webm format, It is, but the crop rectangle must be specified at the container level, and not the codec level like it is with Theora. I would not be surprised if whatever you used to do the conversion didn't preserve it correctly.
Created attachment 547745 [details] [diff] [review] Patch v1 -- Added offset test back I finally managed to get an offset reftest working, so the suite is now as complete as the ogg testsuite. I used mkvmerge --cropping 1:29,4,6,31 --display-dimension 1:29x29 to get a correct video.
kinetik, several of these tests are failing on OSX 64bit. I've set up a mac today to try to reproduce the failure, but I haven't been successful so far. I plan to investigate tomorrow. try push : http://tbpl.mozilla.org/?tree=Try&rev=01e26493cec8
Paul, can you please remove poster-14.html before you check in? It's an invalid test; see bug 622059.
Created attachment 549355 [details] [diff] [review] Patch v2 - Removed invalid test poster-14 Here is the same patch without the test mentioned in the previous comment.
6 years ago