578016 - Clicking the Toggle Toolbars (pill) button on Mac OS should affect View -> Toolbars

Status: VERIFIED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Rimas Kudelis [use needinfo to ping]]

This bug is about one of the problems I described in bug 578013:

Clicking the Toggle Toolbars button on Mac OS (the one in the far right of window title) currently simply hides the toolbar, but they can still be toggled (with no visible effect) using the View -> Toolbars menu. I think that's quite a misbehaviour. I see too possible solutions to this problem:
1) uncheck all toolbars in View -> Toolbars when that button is clicked, and allow to check and enable each of them individually. A drawback for this solution would be that after re-enabling just one toolbar, the Toggle Toolbars button should then again hide it instead of showing others. And that single toolbar would become the new "set" of toolbars that would be enabled on clicking Toggle Toolbars button again.
2) disable the View -> Toolbars menu when the toolbars are toggled off. A potential drawback here is that unless the user doesn't know what the Toggle Toolbars button does, they won't know how to get the toolbars back.

I personally think that option 2 is better, because the Toggle Toolbars button is standard on OS X, so the user should know what it does. Someone else may prefer option 1 though...

Comment 1

[philippe (part-time)]

That Toggle Toolbars button has lots of problems and inconsistencies on OS X, and more so in Fx 4b1 or newer. 
A while ago, I filed bug 573412 for the fact that toggling using the button hides everything, expected: only hide the main toolbar.

Comment 2

[Rimas Kudelis [use needinfo to ping]]

By the way, there's also a third option: to remove the pill button from our title bar. Safari and Opera do that, not sure why though. Perhaps there's an explanation in Apple's HIG with regards to it?

Comment 3

[Dão Gottwald [:dao]]

wontfix per bug 573412

Comment 4

[Emanuele Alimonda]

(In reply to comment #2)

Apple HIG are very explicit on this:
"The title bar should include a toolbar control if a toolbar is present in the window (see “Toolbars”)."

And this applies to all kinds of windows, not only to document ones.

source: http://developer.apple.com/mac/library/documentation/userexperience/conceptual/applehiguidelines/XHIGWindows/XHIGWindows.html#//apple_ref/doc/uid/20000961-TP9

If Safari or Opera don't follow the guidelines, thus looking "broken", why should Firefox mimic them?  If the reason is to move the tabs to the title bar in future, it's not good, per Apple guidelines:
"The only controls that belong in a title bar are the close, minimize, and zoom buttons. If a title bar is combined with a toolbar, the unified area can contain the toolbar control and the toolbar customization contextual menu (these controls are described in “Title Bar Buttons”). Do not place other controls in a title bar."

Source: same as above

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Emanuele, please see bug 573412 which has been removed the toolbar control widget from the toolbar. As given in the last comment on bug 573412 a new bug should be filed. As I can see it didn't happen so far. So if you can create a new bug, comment the exact same text and give us the bug # on bug 573412 it would be great. Thanks.