578018 - Contextmenu is show even if preventDefault has been called

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Some websites want to prevent showing a context menu for some elements and use the tricks to add a oncontextmenu="return false;" to do that.

Also if the preventDefault has been called by a chrome extension we should not show the context menu popup.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This patch does the same as previous but also include a fix for the timeout to be slower because it was firing too fast because of the delay use to wait for the double click. (and other solution is potentially to fired a mouse cancel during the mouseup)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 456844 [details] [diff] [review]
Patch v0.2

>diff -r 4e38010bf28a chrome/content/content.js

>-        this._startContextTimeout(element);
>+        this._contextTimeout.once(700, function() {
>+          let event = content.document.createEvent("PopupEvents");
>+          event.initEvent("contextmenu", true, true);
>+          element.dispatchEvent(event);

Maybe we could use the preference for the timeout length. I think it is "ui.click_hold_context_menus.delay"

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/364a7d0d3b25

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED based on a BFT run of FormFill Helper on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010713 Namoroka/4.0b2pre Fennec/2.0a1pre