578124 - TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/555388-1-ref.html | application timed out after 330 seconds with no output

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Armen [:armenzg]]

After enabling reftests for Direct 2D we are hitting this failure in this test suite.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1278952160.1278953225.1644.gz

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This seems to be dumping the wrong crash.

Comment 2

[(not currently active) Ted Mielczarek]

No, the browser looked hung to the harness (no output) so it injected that thread into the process to crash it and get a stack.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #2)
> No, the browser looked hung to the harness (no output) so it injected that
> thread into the process to crash it and get a stack.

Yep, that makes sense.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Don't create an A8 surface with GDI compatible flags

CreateTexture2D doesn't support creating FORMAT_A8 textures with GDI_COMPATIBLE so we avoid doing so. The patch is a little bit bigger because of some reorganization.

Also add a check for the return value of the QueryInterface in get_dc()

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to comment #1)
> This seems to be dumping the wrong crash.

If you have suggestions for how to make that clearer in the output, I'm all ears!

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #5)
> (In reply to comment #1)
> > This seems to be dumping the wrong crash.
> 
> If you have suggestions for how to make that clearer in the output, I'm all
> ears!

How about giving the CrashingThread() symbol a better name like CrashTimedOutProcess()?

Comment 7

[Bas Schouten (:bas.schouten)]

Comment on attachment 457116 [details] [diff] [review]
Don't create an A8 surface with GDI compatible flags

The rationale for not testing the QueryInterface can be found in http://msdn.microsoft.com/en-us/library/dd371321%28VS.85%29.aspx

'Note that the QueryInterface method always succeeds; if the render target doesn't support the ID2D1GdiInteropRenderTarget interface, calling GetDC will fail. (For render targets created through the CreateCompatibleRenderTarget method, the render target that created it must have these settings.)'

Additionally this should also be done for cairo_d2d_surface_create.

>@@ -2497,29 +2505,31 @@ cairo_d2d_get_dc(cairo_surface_t *surfac
>     if (!d2dsurf->isDrawing) {
>       /* GetDC must be called between BeginDraw/EndDraw */
>       d2dsurf->rt->BeginDraw();
>       d2dsurf->isDrawing = true;
>     }
> 
>     RefPtr<ID2D1GdiInteropRenderTarget> interopRT;
> 
>-    d2dsurf->rt->QueryInterface(&interopRT);
>-
>-    HDC retval;
>-    HRESULT rv;
>-
>-    rv = interopRT->GetDC(retain_contents ? D2D1_DC_INITIALIZE_MODE_COPY :
>-	D2D1_DC_INITIALIZE_MODE_CLEAR, &retval);
>+    HRESULT rv = d2dsurf->rt->QueryInterface(&interopRT);
> 
>     if (FAILED(rv)) {
> 	return NULL;
>     }
> 
>-    return retval;
>+    HDC dc;
>+    rv = interopRT->GetDC(retain_contents ? D2D1_DC_INITIALIZE_MODE_COPY :
>+	D2D1_DC_INITIALIZE_MODE_CLEAR, &dc);
>+
>+    if (FAILED(rv)) {
>+	return NULL;
>+    }
>+
>+    return dc;
> }
> 
> void
> cairo_d2d_release_dc(cairo_surface_t *surface, const cairo_rectangle_int_t *updated_rect)
> {
>     if (surface->type != CAIRO_SURFACE_TYPE_D2D) {
>         return;
>     }

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Don't create an A8 surface with GDI compatible flags v2

Comment 9

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/16e80bf00c1b