578110 - (d2d-reftest) [tracking bug] reftest Direct 2D oranges

Status: RESOLVED WONTFIX

(Core :: Graphics, defect, P4)

Description

[Armen [:armenzg]]

We now are running the reftest test suite with Direct 2D enabled (this was enabled in bug 549120).
I will use this bug to track all known oranges and crashes.
This bug will also be tracked under the known Windows 7 unit test oranges.

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bidi/visualmarquee.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bidi/logicalmarquee.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/box-shadow/boxshadow-rounded-spread.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/box-shadow/boxshadow-onecorner.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/289480.html#top |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/379349-1b.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/379349-1c.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/385569-1a.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/385569-1b.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/456219-1a.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/456219-1b.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/456219-1c.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/456219-2.html |
TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/555388-1-ref.html | application timed out after 330 seconds with no output
PROCESS-CRASH | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/bugs/555388-1-ref.html | application crashed (minidump found)
Thread 17 (crashed)

Comment 1

[Armen [:armenzg]]

NOTE that the reftest-d2d is currently hidden.

For reference:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1278954099.1278955494.8641.gz

Here is the summary of all filed oranges:
* bug 578127 - bidi/visualmarquee.html, logicalmarquee.html
* bug 578134 - box-shadow/boxshadow-rounded-spread.html
* bug 578135 - box-shadow/boxshadow-onecorner.html
* bug 578114 - bugs/289480.html#top
* bug 578116 - 379349-1b.xhtml, 379349-1c.xhtml
* bug 578118 - 385569-1a.html, 385569-1b.html
* bug 578121 - 456219-1a.html, 456219-1b.html, bugs/456219-1c.html, 456219-2.html
* bug 578124 - 555388-1-ref.html

The highest priority to fix is bug 578124 since it currently crashes (from timing out?) and stops running all other tests (therefore, there could be even more oranges)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Jonathan, can you attack these? Especially bug 578124

Comment 3

[Bas Schouten (:bas.schouten)]

(In reply to comment #2)
> Jonathan, can you attack these? Especially bug 578124

I suspect you mean 578127?

Comment 4

[Joe Drew (not getting mail)]

All of these reftest failures block a beta (probably beta 4).

Comment 5

[Armen [:armenzg]]

I have just changed which bug to block.

I want to keep bug 562489 to only track bugs that stop us from stop running unit tests on win2k3 builders. D2D tests are not being run on the builders and therefore there is no need to count it as a blocker.

Good luck with the remaining oranges!

Comment 6

[Joe Drew (not getting mail)]

Just assigning to you so that there's an assignee.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Here are the unaccounted for reftest failures so far:

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/bugs/379349-1b.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/bugs/379349-1c.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/bugs/482592-1a.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/bugs/482592-1b.xhtml |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/linear-repeat-1d.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/linear-repeat-1g.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/repeating-linear-1a.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/repeating-linear-1b.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/table-anonymous-boxes/394402-1a.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/text-decoration/underline-block-propagation-2-stand
ards.html |

Comment 8

[Bas Schouten (:bas.schouten)]

I believe these are flavors of Bug 582236. The causes of them are understood, we position the gradient in a different manner for each case. If D2D wouldn't be sampling a gradient texture they'd look identical, if we do use a gradient texture the different placements seem to cause slightly different sampling:

REFTEST TEST-UNEXPECTED-FAIL |
file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/linear-repeat-1d.html
|
REFTEST TEST-UNEXPECTED-FAIL |
file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/linear-repeat-1g.html
|
REFTEST TEST-UNEXPECTED-FAIL |
file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/repeating-linear-1a.html
|
REFTEST TEST-UNEXPECTED-FAIL |
file:///c:/Users/jrmuizel/mozilla-central/layout/reftests/css-gradients/repeating-linear-1b.html

Comment 9

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #8)
> I believe these are flavors of Bug 582236. The causes of them are understood,
> we position the gradient in a different manner for each case. If D2D wouldn't
> be sampling a gradient texture they'd look identical, if we do use a gradient
> texture the different placements seem to cause slightly different sampling:

I haven't looked at the tests yet, but do you know what is up with the black strip at the bottom of them? Is this just an additional stop that we're interpolating with?

Comment 10

[Jeff Muizelaar [:jrmuizel]]

There are two remaining unexplained test failures:

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/birch_win7_test-reftest-d2d/build/reftest/tests/layout/reftests/image-element/element-paint-transform-02.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/birch_win7_test-reftest-d2d/build/reftest/tests/layout/reftests/svg/smil/container/deferred-anim-1.xhtml |

Comment 11

[Shawn Wilsher :sdwilsh]

Since d2d is not being turned on for beta4, I don't believe this needs to block b4 anymore either.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

But d2d is being turned on for beta5; what's the status of this? We've been adding more dependencies than removing, lately.

Comment 13

[Joe Drew (not getting mail)]

There are no reftests that fail on mozilla-central due to d2d. This will remain a tracking bug for fixing any underlying issues for tests that we just disabled on D2D.

Comment 14

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Joe Drew (:JOEDREW! \o/) from comment #13)
> There are no reftests that fail on mozilla-central due to d2d. This will
> remain a tracking bug for fixing any underlying issues for tests that we
> just disabled on D2D.

Found in triage. This bug is 2.5 years since last comment. If there's anything left to do, can someone clarify what needs to be done, and by whom?

Comment 15

[Joe Drew (not getting mail)]

Bas is going to have to comment on this; I don't know whether there are any still outstanding.

Comment 16

[Armen [:armenzg]]

As I understand, this bug tracks a bunch of tests that got disabled to allow us to enabled certain test suites.
I don't know where the d2d tests run inside of and it is not necessary to determine what is the status of this bug.
This bug does not belong to Releng but to GFX to determine which of the disabled tests can be re-enabled or left as-is.

If my understanding is incorrect please let us know.
There's nothing on the Releng side that needs to be done afaik.