If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/box-shadow/boxshadow-rounded-spread.html

RESOLVED WORKSFORME

Status

()

Core
Layout: View Rendering
RESOLVED WORKSFORME
7 years ago
5 years ago

People

(Reporter: armenzg, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug, {intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [win7])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 456907 [details]
log

After enabling reftests for Direct 2D we are hitting this failure in this test suite.
Created attachment 456909 [details]
analyzed log

There are a very small number of divergent pixels on the outer edge of the circle.  I have no idea whether it is practical to fix that.
(In reply to comment #1)
> Created attachment 456909 [details]
> analyzed log
> 
> There are a very small number of divergent pixels on the outer edge of the
> circle.  I have no idea whether it is practical to fix that.

If that becomes the formal decision from Dev, can the test be modified to return green for that case?
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 456909 [details] [details]
> > analyzed log
> > 
> > There are a very small number of divergent pixels on the outer edge of the
> > circle.  I have no idea whether it is practical to fix that.
> 
> If that becomes the formal decision from Dev, can the test be modified to
> return green for that case?

I expect so yes.
(In reply to comment #2)
> (In reply to comment #1)
> > Created attachment 456909 [details] [details]
> > analyzed log
> > 
> > There are a very small number of divergent pixels on the outer edge of the
> > circle.  I have no idea whether it is practical to fix that.
> 
> If that becomes the formal decision from Dev, can the test be modified to
> return green for that case?

We've talked fuzzy matching before, but it's a tricky area. And additionally it's probably only a good idea if we understand why there are these tiny discrepancies.
(Assignee)

Updated

7 years ago
Depends on: 580786
Assignee: nobody → jmuizelaar
I actually think that what we should do here is change nsCSSRendering::PaintBackgroundWithSC to paint the background color by filling the background shape instead of clipping to the background shape and then filling the dirty area. This should actually be faster as well as making these test failures go away.
Blocks: 438871

Comment 6

5 years ago
Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
Keywords: intermittent-failure
Whiteboard: [win7][orange] → [win7]
You need to log in before you can comment on or make changes to this bug.