Closed
Bug 578197
Opened 14 years ago
Closed 14 years ago
[PostgreSQL] Fix old altered-to-serial columns that weren't upgraded as well as they could have been
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(2 files)
1.28 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
750 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
The flagtypes.id and keyworddefs.id tables were, at one point in the history of Pg Bugzilla, altered to be SERIAL types. However, our new Pg 8.3-specific code on trunk does a better job of upgrading SERIAL types than our pre-8.3 code did. So we should probably fix the current flagtypes.id and keyworddefs.id columns to be just as good as though they were upgraded via the modern code.
(This is currently causing our checksetup-pg tinderbox to turn orange.)
Assignee | ||
Comment 1•14 years ago
|
||
Okay, this associates columns with sequences properly, which I believe is the only modification required.
Assignee | ||
Updated•14 years ago
|
Flags: approval+
Assignee | ||
Comment 2•14 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Pg.pm
Committed revision 7330.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•14 years ago
|
||
This requires one additional fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•14 years ago
|
||
I'll also need to update this manually on landfill, because bugs_tip was already updated with the previous code.
Attachment #456976 -
Flags: review+
Assignee | ||
Comment 5•14 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Pg.pm
Committed revision 7332
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•