Closed Bug 578197 Opened 14 years ago Closed 14 years ago

[PostgreSQL] Fix old altered-to-serial columns that weren't upgraded as well as they could have been

Categories

(Bugzilla :: Installation & Upgrading, defect)

3.7.2
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(2 files)

The flagtypes.id and keyworddefs.id tables were, at one point in the history of Pg Bugzilla, altered to be SERIAL types. However, our new Pg 8.3-specific code on trunk does a better job of upgrading SERIAL types than our pre-8.3 code did. So we should probably fix the current flagtypes.id and keyworddefs.id columns to be just as good as though they were upgraded via the modern code. (This is currently causing our checksetup-pg tinderbox to turn orange.)
Depends on: 577793
Attached patch v1Splinter Review
Okay, this associates columns with sequences properly, which I believe is the only modification required.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #456961 - Flags: review+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/DB/Pg.pm Committed revision 7330.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This requires one additional fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Extra FixSplinter Review
I'll also need to update this manually on landfill, because bugs_tip was already updated with the previous code.
Attachment #456976 - Flags: review+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/DB/Pg.pm Committed revision 7332
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: