577793 - Improve the Pg SERIAL-altering code now that we require 8.3

Status: RESOLVED FIXED

(Bugzilla :: Database, enhancement)

Description

[Max Kanat-Alexander]

There were some things we couldn't quite do right with SERIAL type fields when doing an ALTER on them, in older versions of Pg. However, Pg 8.3 pretty much adds all the support we needed, so we should use the newer, better support.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

We now use ALTER SEQUENCE instead of ALTER TABLE to rename sequences--this fixes the column defaults without us having to do anything else.

When adding a new sequence, we do "OWNED BY table.column" so that the sequence will be automatically dropped if the table or column get dropped.

We now actually drop the sequence if a column stops being serial (which hasn't happened in Pg-support history, but could in the future).

Comment 2

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Schema/Pg.pm
Committed revision 7318.

Comment 3

[Max Kanat-Alexander]

  Okay, this needs one more fix because it can be considered complete.

Comment 4

[Max Kanat-Alexander]

Attachment: Extra Fix

Comment 5

[Max Kanat-Alexander]

Comment on attachment 456975 [details] [diff] [review]
Extra Fix

Wrong bug.

Comment 6

[Max Kanat-Alexander]

I reopened the wrong bug.