578377 - Quick Filter Bar returns after being removed

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Neville Hillyer]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_5_8; en-us) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-GB; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1

Selecting TB via its dock icon brings back the previously removed Quick Filter Bar.

Reproducible: Always

Steps to Reproduce:
1 - Launch TB
2 - Deselect Quick Filter Bar
3 - Close TB windows
4 - Hit TB dock icon
5 - Note that Quick Filter Bar has returned


Expected Results:  
TB should remember status of Quick Filter Bar.

Comment 1

[Neville Hillyer]

It also occurs if 3 is replaced by cmd-w and 4 is replaced by cmd-1.

Comment 2

[Neville Hillyer]

Please don't change my original summary so that it inadequately reflect the situation - see comment 1

I have not examined other ways of triggering this setting instability.

See also;

https://bugzilla.mozilla.org/show_bug.cgi?id=575864

Comment 3

[Larry Gusaas]

I get the same behaviour as original post and comment 1 on Intel Mac withe OS 10.6.4

Comment 4

[Neville Hillyer]

I can report that this bug still exists in TB 3.1.1

Comment 5

[Neville Hillyer]

Here is a simple fix for this:

Find 'const FILTER_VISIBILITY_DEFAULT' in

/Applications/Thunderbird.app/Contents/MacOS/modules/quickFilterManager.js

Change its value from true to false.

This has a similar downside to the patch at https://bugzilla.mozilla.org/show_bug.cgi?id=575864#c20 in that a visible Quick Filter Bar will be removed by window closing and opening, ie it now defaults to no Quick Filter Bar. However in this case it is quickly remedied by cmd F.

Comment 6

[Larry Gusaas]

(In reply to comment #5)
> Here is a simple fix for this:

Thank you. Your fix works and stops a very annoying behaviour. It is much simpler to open the Quick Filter Bar when I want to use it (Very seldom) rather than constantly having to close it.

Comment 7

[Neville Hillyer]

There is now a much better patch for both bugs at:

https://bugzilla.mozilla.org/show_bug.cgi?id=575864#c39

Comment 8

[Neville Hillyer]

Please ignore comment 7 - it failed after further tests.

Comment 9

[Neville Hillyer]

This reasonably well tested patch from David Bienvenu appears to resolve both the Quick Filter Bar and Message Pane bugs. Details at bug 575864. The following may be useful for Mac users who want to patch their TB now. This is what I did to a standard TB 3.1.1 install (ie after removing all previous experimental patches)

1 - Opened:

   /Applications/Thunderbird.app/Contents/MacOS/modules/sessionStoreManager.js

2 - Replaced:

   sessionFile.remove(false);

With:

    sessionFile.remove(false);
    this._currentStateString = null;

3 - Replaced:

   let firstWindow = !this._initialized;

With:

   let firstWindow = !this._initialized || this._shutdownStateSaved;

4 - Saved and tested.

Comment 11

[Neville Hillyer]

I am going to mark this as resolved/fixed since the recently resolved bug 575864 will also resolve this bug.