578520 - [k] Ability to upload images

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Paul Craciunoiu [:paulc]]

After bug 569033, we will need the ability to upload images. This bug handles that, probably enabling uploads from both the forums and questions apps.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: point `/upload/` to kitsune

Adds a rewrite for the upcoming kitsune upload app.

Comment 2

[Erik Rose [:erik][:erikrose]]

> RewriteRule ^upload(.*) /k/upload$1 [L,QSA]

How about ($|/.*) instead of (.*) so it doesn't match "uploadinationification"?

> RewriteRule ^([\-a-zA-Z]+)/upload(.*) /k/$1/upload$2 [L,QSA]

You don't need the backslash before -, do you? And same as above for (.*).

Comment 3

[James Socol [:jsocol, :james]]

Comment on attachment 459192 [details] [diff] [review]
point `/upload/` to kitsune

WFM.

This is the style we've been using for all the other apps. Rewriting /uploadusifnse is fine, as it triggers a nicer 404 page than it would otherwise.

Comment 4

[Paul Craciunoiu [:paulc]]

r71049 on trunk for attachment 459192 [details] [diff] [review].

Comment 5

[Rebecca Billings [:rbillings]]

how is this different than adding an image path into a forum post/question?

Comment 6

[James Socol [:jsocol, :james]]

This bug is about giving us the ability to upload images (or files) through Kitsune to SUMO. We don't currently have another way of doing that.

Comment 7

[James Socol [:jsocol, :james]]

This landed and all the relevant SQL ran. We're waiting on bug 582812 to get libjpeg installed.

Comment 8

[Rebecca Billings [:rbillings]]

Verified able to upload images

Comment 9

[David Tenser [:djst]]

That, and it's looking really good!