dead code removal: browserOverlay.xul

NEW
Unassigned

Status

--
minor
8 years ago
3 years ago

People

(Reporter: crussell, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

Created attachment 457390 [details] [diff] [review]
remove browserOverlay.dtd and remove entities used only in that file from all localizations

We stopped shipping it in 2001, but it's been hanging around this whole time.
Attachment #457390 - Flags: review?(neil)
OS: Linux → All
Hardware: x86 → All
Assignee: nobody → Sevenspade

Comment 1

8 years ago
What about the entities for the commented-out preference element to turn it on?

(It might be simpler to fix and enable the overlay!)
Summary: dead code removal: browserOverlay.dtd → dead code removal: browserOverlay.xul
Severity: normal → minor
Version: unspecified → Trunk
Created attachment 609141 [details] [diff] [review]
(Bv1) Remove browserOverlay.xul and venkmanOverlay.xul remnants

Bah, I just noticed this too ;->

(In reply to neil@parkwaycc.co.uk from comment #1)

> What about the entities for the commented-out preference element to turn it
> on?

This patch touches en-US only: I'll do the other locales before checkin.

> (It might be simpler to fix and enable the overlay!)

I think browserOverlay.xul was replaced by tasksOverlay-ff.xul.

Maybe venkmanOverlay.xul could "become" a tasksOverlay-jsd.xul, like tasksOverlay-cz.xul?
(Not sure if it's worth it.)
Attachment #609141 - Flags: review?(neil)
Attachment #609141 - Flags: feedback?(Sevenspade)

Comment 3

7 years ago
(In reply to Serge Gautherie from comment #2)
> I think browserOverlay.xul was replaced by tasksOverlay-ff.xul.
The Navigator references make it quite clear that it is unrelated ;-)
What kind of feedback are you looking for?
Comment on attachment 609141 [details] [diff] [review]
(Bv1) Remove browserOverlay.xul and venkmanOverlay.xul remnants

Removing feedback=me.  See comment 4
Attachment #609141 - Flags: feedback?(Sevenspade)
Assignee: Sevenspade → nobody
Attachment #457390 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.