578817 - Drop download.old.js

Status: RESOLVED WONTFIX

(www.mozilla.org :: General, defect)

Description

[Alex Buchanan [:abuchanan]]

It's time this file goes bye bye, to be replaced with download.js

I did a quick test, and it seems replacing old-style download buttons is fairly straightforward (I'll post a sample patch soon).  

A few tweaks are needed

* Tweak product-details so that download button style matches what is currently on mozilla.com/en-US/.  The changes are very minor.  Pascal, this would affect mozilla-europe download buttons, and in fact anyone using product-details (hopefully you agree it makes them look nicer)

* Look for edge cases implemented in download.old but not download.js.  I'm thinking of edge cases like this...

// Special case for Opera on OS X emulating IE (bug 402113)
if ((navigator.userAgent.indexOf("Opera") != -1) && (navigator.userAgent.indexOf("Opera 6") == -1)) {
    gPlatform = PLATFORM_MACOSX;
}

Comment 1

[Alex Buchanan [:abuchanan]]

Attachment: sample patch for removing download.old from en-US home page

Comment 2

[Alex Buchanan [:abuchanan]]

Oh, another tweak to do:

* add the '10.4 and above' part for Mac OS X (fix for bug 439792)

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 457400 [details] [diff] [review]
sample patch for removing download.old from en-US home page

conceptually, it looks fine to me :)

Comment 4

[Pascal Chevrel:pascalc]

fyi, I am working on making an l10n version of the firefox 4beta page and download.old.js is used there.

Comment 5

[Chris More [:cmore]]

Closing old Mozilla.org website bugs due to them not being relevant to the new Python-based Bedrock system. Re-open if this is a critical bug and should be resolved on the new system too.

Comment 6

[Samuel Sidler (:ss)]

Alex, did this get fixed?