579258 - Remove nsIWidget::Scroll and related code

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Post 564991, it is no longer used.

There is also scroll analysis code in nsDisplayList.cpp that is no longer used.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: refactor IsVaryingRelativeToMovingFrame

Change IsVaryingRelativeToMovingFrame to take the "moving frame" as a direct parameter instead of getting it from the builder. This simplifies things a bit and makes it easier to remove all the other code related to "moving frames".

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: Remove remaining "moving frame" code

Mostly removing the "before move" region parameter to ComputeVisibility, which is totally unused now.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 3: remove nsIWidget::Scroll

This is purely removing dead code.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 462327 [details] [diff] [review]
Part 3: remove nsIWidget::Scroll

nsSimpleRef<pixman_region32> and pixman.h can also be removed from
gtk2/nsWindow.cpp.

$(MOZ_CAIRO_LIBS) can be removed from gtk2/Makefile.in.

Probably $(MOZ_CAIRO_CFLAGS) can also be removed, though I'm not sure how
gfxASurface.h gets cairo.h.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #4)
> Comment on attachment 462327 [details] [diff] [review]
> Part 3: remove nsIWidget::Scroll
> 
> nsSimpleRef<pixman_region32> and pixman.h can also be removed from
> gtk2/nsWindow.cpp.

Actually it can't, nsWindow::SetWindowClipRegion still uses it.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 462324 [details] [diff] [review]
Part 1: refactor IsVaryingRelativeToMovingFrame

Removing dead code

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 462326 [details] [diff] [review]
Part 2: Remove remaining "moving frame" code

remove dead code

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 462327 [details] [diff] [review]
Part 3: remove nsIWidget::Scroll

remove dead code

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/f62609dc783f
http://hg.mozilla.org/mozilla-central/rev/4fbf9e1464c3
http://hg.mozilla.org/mozilla-central/rev/c6363df91109