579340 - Miscellaneous code cleanup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch fixes two things:
* BrowserView::updateScrolledArea does not check to make sure "tab" is valid. It can be null when about:blank pre-pages load faster than we put the new tab in the Browser.tabs collection. We want to ignore those anyway and fix them in the future. BrowserView is destined for the scrape heap anyway.
* importDialog reuses the "parent" variable for two different things: the parent DOM node and the parent window. The patch uses aParent for the passed in param and parentNode for the DOM node.

See
http://hg.mozilla.org/mobile-browser/diff/c21d7d3748a8/chrome/content/browser.js for the original 'parent' DOM node

http://hg.mozilla.org/mobile-browser/rev/b8146a648664 for the addition of the 'parent' param

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 457855 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js
>--- a/chrome/content/browser.js
>+++ b/chrome/content/browser.js

>   // we need to insert before select-container if we want it to show correctly
>   let selectContainer = document.getElementById("select-container");
>-  let parent = selectContainer.parentNode;
>+  let parentNode = selectContainer.parentNode;
> 

I'm happy this "parent" var was being insult by xpcshell for a while (bug 539461) and your patch correct what I've not seen when cleaning it.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/93baa2cdfc1f

Comment 3

[Dão Gottwald [:dao]]

bugspam