Closed
Bug 579737
Opened 14 years ago
Closed 14 years ago
Make lightweight themes / personas work with browser on Mac
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a3
People
(Reporter: kairo, Assigned: stefanh)
References
Details
Attachments
(3 files, 1 obsolete file)
507.24 KB,
image/png
|
Details | |
74.27 KB,
image/png
|
Details | |
4.84 KB,
patch
|
mnyromyr
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Bug 563261 makes lwthemes installable and makes it work with browser on Windows and Linux, as I can't test on Mac, I can't see how it looks and works there, we need someone familiar with Mac to do it there.
Comment 1•14 years ago
|
||
I see problem with Bookmarks toolbar.
Reporter | ||
Comment 2•14 years ago
|
||
Of course you see a problem, as no work has been done in here yet. As I don't have a Mac, I can't work on this, as I can't test it. Help wanted!
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #1) > I see problem with Bookmarks toolbar. I can fix that, don't worry ;-) Can you see if there are any more issues? For example, do you think tab bar and tabs looks ok?
Assignee: nobody → stefanh
Comment 4•14 years ago
|
||
As I promissed yesterday I have a look at SeaMonkey on Mac OS X again. Problems: * Website navigation bar doesn't have Persona. * Tabbar doesn't have Persona on background.
Assignee | ||
Comment 5•14 years ago
|
||
Fixes all things reported here and some nits like tab borders and tab hover styling (needs to be re-visited when mailNews gets personas-friendly) A few comments: - hover:active on disabled linkToolbar items worked on disabled items (non-personas too) - I had to do some non-lwtheme changes in tabbrowser.css to make it work - I have some changes to sidebar too, but I'll wait with them since it needs more work
Attachment #460299 -
Flags: superreview?(neil)
Attachment #460299 -
Flags: review?(mnyromyr)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•14 years ago
|
||
Once thing that I haven't solved in personas is that only some PT bookmark items gets their text-shadow changed on hover:active.
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #6) > Once thing that I haven't solved in personas is that only some PT bookmark > items gets their text-shadow changed on hover:active. Sorry, forget about that - this depends on the background!
Comment 8•14 years ago
|
||
Comment on attachment 460299 [details] [diff] [review] Make mac classic browser personas-friendly >-#linktoolbar > .bookmark-item:hover:active, >+#linktoolbar > .bookmark-item:not([disabled="true"]):hover:active, I guess this is really a separate bug ;-) >-.bookmark-item[container="true"]:hover:active { >+.bookmark-item:not([disabled="true"])[container="true"]:hover:active { Although I don't think bookmark items can be disabled, can they? >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(ltr) { >+ -moz-border-left-colors: transparent transparent; >+} >+ >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(rtl) { >+ -moz-border-right-colors: transparent transparent; >+} What styles are these overriding?
Assignee | ||
Comment 9•14 years ago
|
||
(In reply to comment #8) > Comment on attachment 460299 [details] [diff] [review] > Make mac classic browser personas-friendly > > >-#linktoolbar > .bookmark-item:hover:active, > >+#linktoolbar > .bookmark-item:not([disabled="true"]):hover:active, > I guess this is really a separate bug ;-) Right, OK. > > >-.bookmark-item[container="true"]:hover:active { > >+.bookmark-item:not([disabled="true"])[container="true"]:hover:active { > Although I don't think bookmark items can be disabled, can they? Well, the "Document" and "More" items in the linkToolbar are of class .bookmark-item ;-). I could add the rules there, of course. > > >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(ltr) { > >+ -moz-border-left-colors: transparent transparent; > >+} > >+ > >+.tabbrowser-tab[afterselected="true"]:-moz-lwtheme:-moz-locale-dir(rtl) { > >+ -moz-border-right-colors: transparent transparent; > >+} > What styles are these overriding? Hmm, this must have been a leftover from me playing with the rules. I'll remove it.
Assignee | ||
Comment 10•14 years ago
|
||
I kept this, because it really affects personas -toolbarbutton.bookmark-item[disabled="true"], -toolbarbutton.bookmark-item[disabled="true"][container="true"] { +toolbarbutton.bookmark-item[disabled="true"] > .toolbarbutton-icon , +toolbarbutton.bookmark-item[disabled="true"][container="true"] > .toolbarbutton-icon { opacity: 0.5 !important; }
Attachment #460299 -
Attachment is obsolete: true
Attachment #460643 -
Flags: superreview?(neil)
Attachment #460643 -
Flags: review?(mnyromyr)
Attachment #460299 -
Flags: superreview?(neil)
Attachment #460299 -
Flags: review?(mnyromyr)
Comment 11•14 years ago
|
||
Comment on attachment 460643 [details] [diff] [review] New version > >-.tabbrowser-tab:-moz-locale-dir(ltr), >-.tabbrowser-tab:-moz-locale-dir(rtl):first-child { >+ >+.tabbrowser-tab:not([selected="true"]):-moz-locale-dir(ltr), >+.tabbrowser-tab:not([selected="true"]):-moz-locale-dir(rtl):first-child { Nit: extra blank line. > >+ And another.
Attachment #460643 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 12•14 years ago
|
||
Filed bug 582372 for the linkToolbar issue.
Updated•14 years ago
|
Attachment #460643 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 13•14 years ago
|
||
http://hg.mozilla.org/comm-central/rev/0cbc202563a6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Assignee | ||
Comment 14•14 years ago
|
||
I forgot to address comment #11, so I pushed a another changeset (wrong bug # in comment...): http://hg.mozilla.org/comm-central/rev/69d97489bd8a
You need to log in
before you can comment on or make changes to this bug.
Description
•