582372 - [Mac default] hover:active style rules applies on disabled linkToolbar items

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Spun off from bug 579737, comment #8:

Since the hover:active style rules lacks :not([disabled="true"]), clicking a disabled item will apply the hover:active styles. I believe I caused this when I re-did mac classic.

Comment 1

[Stefan [:stefanh]]

Attachment: Fix hover:active styles

One change might need some clarification:
 #bookmarks-button[open="true"],
-.bookmark-item[container="true"]:hover:active {
+.bookmark-item:not([disabled="true"])[container="true"]:hover:active {
   list-style-image: url("chrome://communicator/skin/bookmarks/bookmark-folder-active.png");
 }

These rules are in navigator.css and I think it's better to change them there than to duplicate them in linkToolbar.css

Comment 2

[[e-mail]]

Comment on attachment 463944 [details] [diff] [review]
Fix hover:active styles

>+#linktoolbar > .bookmark-item:not([disabled="true"])[container="true"]:hover:active {

>+.bookmark-item:not([disabled="true"])[container="true"]:hover:active {

I'd prefer .bookmark-item[container="true"]:not([disabled="true"]):hover:active

Comment 3

[Karsten Düsterloh]

Comment on attachment 463944 [details] [diff] [review]
Fix hover:active styles

>+#link-top:not([disabled="true"]:hover:active
>+#link-up:not([disabled="true"]:hover:active
>+#link-first:not([disabled="true"]:hover:active
>+#link-prev:not([disabled="true"]:hover:active
>+#link-next:not([disabled="true"]:hover:active
>+#link-last:not([disabled="true"]:hover:active

Actually, I'd prefer rules not being applied because of their valid selector, not because the selector is broken. :-P
Hint: ( love )...

r=me with that fixed.
(I tested a locally fixed version.)

Comment 4

[Stefan [:stefanh]]

Pushed with comment #2 and comment #3 addressed:

http://hg.mozilla.org/comm-central/rev/bcc622bacd07