Closed Bug 579786 Opened 10 years ago Closed 1 year ago
Qualify accesses to dependent base in js/jetpack/Handle
Per summary; this is required to build Firefox with clang. See bug 573210 comment 6 for an explanation of why clang isn't accepting code gcc does accept. Please redirect this bug if it isn't in the right component or I'm not asking the right person for review; the Bugzilla components aren't very clear, and http://www.mozilla.org/about/owners.html doesn't indicate who owns the code.
Comment on attachment 458216 [details] [diff] [review] Patch Hm, bsmedberg is changing this code in bug 578821, so this may bitrot. Anyway, can we just use |this->| instead of |BaseType::| ?
It's not legal to use "this" in a static method... I think "self->Send__delete__(self)" would work, though, if you'd prefer that.
Sync'ed to tip and changed per review comment.
10 years ago
Attachment #475616 - Flags: review?(bent.mozilla) → review+
Do I need approval2.0+ to commit this? If so, how do I request it?
Closing all inactive bugs in Mozilla labs :: * Please reopen if this are still relevant.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.