579862 - Consider using SETLOCAL in start-*.bat

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[[e-mail]]

So that you don't pollute the parent command prompt's environment.
[guess-msvc.bat gets confused if you run it twice]

Comment 1

[[e-mail]]

Attachment: Possible patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 458304 [details] [diff] [review]
Possible patch

I...don't actually know what this does.

Comment 3

[[e-mail]]

C:\>SETLOCAL /?
Begins localization of environment changes in a batch file.  Environment
changes made after SETLOCAL has been issued are local to the batch file.
ENDLOCAL must be issued to restore the previous settings.  When the end
of a batch script is reached, an implied ENDLOCAL is executed for any
outstanding SETLOCAL commands issued by that batch script.

Comment 4

[(not currently active) Ted Mielczarek]

With bug 579860, does this mean that none of the variables set in the start-msvc* batch files will persist into the bash environment? Or do they make it there, and just not afterwards if you run it from a command prompt?

Comment 5

[[e-mail]]

SETLOCAL only affects the calling command prompt. Applications run with or without start inherit environment variables from the batch file as normal.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 458304 [details] [diff] [review]
Possible patch

Okay.

Comment 7

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/mozilla-build/rev/a9eac499f12e