fake server timeout ends xpcshell tests successfully.

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
If a fake server times out waiting for a request (which it does after 3 minutes, NNTP-much? :-)), it calls do_test_finished(), which makes it look like everything succeeded. This makes it difficult to write a test that fails using the async test driver framework (e.g., an expected notification doesn't arrive). My inclination is to either make the server throw an error on timeout, or at minimum, not call do_test_finished(). I'm not keen on waiting 10 minutes for a test to fail, but having the server throw an exception on timeout seems inappropriate.
(Assignee)

Comment 1

8 years ago
Created attachment 458672 [details] [diff] [review]
proposed fix
Assignee: nobody → bienvenu
Attachment #458672 - Flags: review?(bugzilla)
Attachment #458672 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 2

8 years ago
fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.