Closed
Bug 580108
Opened 14 years ago
Closed 14 years ago
fake server timeout ends xpcshell tests successfully.
Categories
(Thunderbird :: Testing Infrastructure, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Bienvenu, Assigned: Bienvenu)
References
Details
Attachments
(1 file)
820 bytes,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
If a fake server times out waiting for a request (which it does after 3 minutes, NNTP-much? :-)), it calls do_test_finished(), which makes it look like everything succeeded. This makes it difficult to write a test that fails using the async test driver framework (e.g., an expected notification doesn't arrive). My inclination is to either make the server throw an error on timeout, or at minimum, not call do_test_finished(). I'm not keen on waiting 10 minutes for a test to fail, but having the server throw an exception on timeout seems inappropriate.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → bienvenu
Attachment #458672 -
Flags: review?(bugzilla)
Updated•14 years ago
|
Attachment #458672 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 2•14 years ago
|
||
fixed on trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•