580375 - Land Breakpad patch from r626 in mozilla-central

Status: RESOLVED WONTFIX

(Toolkit :: Crash Reporting, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

In https://bugzilla.mozilla.org/show_bug.cgi?id=577431#c30, jimb got upstream fixes in place for better memory usage.

We need to pickup these upstream patches to get 10.6 build symbols.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

This was last done in bug#567424 by Ted. He's out right now - anyone else who can do this?

Comment 2

[Jim Blandy :jimb]

Ted's coming back tomorrow (Wed July 21).

Comment 3

[(not currently active) Ted Mielczarek]

I'm backed up from vacation and this is important, so I think we should land just Jim's patch in m-c. It's not as bad as taking a local patch since it's already upstreamed. I've got all our other local patches in the issue tracker, but not actually landed upstream, so there's still a little pain involved.

Comment 4

[Josh Aas]

Attachment: fix v1.0

Comment 5

[Josh Aas]

Attachment: fix v1.0 (against mozilla tree)

Comment 6

[Jim Blandy :jimb]

(In reply to comment #5)
> Created attachment 459070 [details] [diff] [review]
> fix v1.0 (against mozilla tree)

r=me if you need it.

Comment 7

[Josh Aas]

I ran this through the try server with the patch from bug 576053 to enable crashreporter and we had the same problem. This wasn't enough to fix it.

We need to find out if upping the RAM to 2 GB fixes the problem. If it does then we at least know for sure that we're dealing with a memory shortage which causes things to run so slowly that we time out.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

I found a 10.6 mini with 2G of RAM to test on, but we don't have the pile of other 2G machines to re-purpose I thought we did.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Since this is heading a hardware direction I'm going to continue the discussion over in bug 577431.

Comment 10

[Josh Aas]

blocking2.0- since we now know that this isn't enough to fix our problems with 64-bit make buildsymbols.

Comment 11

[Josh Aas]

I don't know if we still want to do this given comment 7. Reassigning to Ted who can make a decision.

Comment 12

[(not currently active) Ted Mielczarek]

We figured out a workaround in bug 577431, so we don't need this immediately. We'll pick it up the next time we sync with upstream.