576053 - enable compiling Breakpad on Mac OS X/x86-64 by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Once we sync to upstream Breakpad (bug 567424) we should be able to turn on Breakpad on OS X x86-64.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: enable Breakpad on OS X/x86-64

Simple patch.

Comment 2

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/f10f90803aaf

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

I had to revert this change, it was causing the build slaves to hang (see bug 577431).

http://hg.mozilla.org/mozilla-central/rev/e83325810760

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Needed for another b3 blocker.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 455444 [details] [diff] [review]
enable Breakpad on OS X/x86-64

Landed again:
http://hg.mozilla.org/mozilla-central/rev/e301cb6bddd6

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Unfortunately the slave for the opt build froze in buildsymbols, so I had disable this again: http://hg.mozilla.org/mozilla-central/rev/dc4f4587d548

The debug build did succeed, so there's some other factor here - free memory/disk/something random. I'll grab a few slaves and put them in a loop building with the patch from bug 580375 to see if it helps. Other suggestion was to try upgrading to 10.6.4, which is known to make building mozilla more reliable.

Comment 7

[(not currently active) Ted Mielczarek]

I don't think this is going to make beta 3. The code all works, but we have a problem running it on our build slaves which only have 1GB of ram. We've tried some workarounds, but I'm out of ideas. bug 577431 has the details.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Landed again http://hg.mozilla.org/mozilla-central/rev/95e7649e256d

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Fixed on mozilla-central. Try will build symbols when bug 584820 is resolved and attachment 464952 [details] [diff] [review] is backed out.

Projects merging from m-c will almost certainly need to clobber their opt and debug builds or hit configure errors in ctypes/libffi. Go to https://build.mozilla.org/clobberer/, set the check box for
  OS X 10.6.2 <branch> build
  OS X 10.6.2 <branch> leak test build
and hit the Clobber button at the bottom of the page, prior to pushing the merge.

Comment 10

[(not currently active) Ted Mielczarek]

This looks good, although we still don't have symbols uploaded:
http://crash-stats.mozilla.com/report/index/7c8915f0-0b7b-49e1-b34f-1156b2100813

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

I'll fix that over on bug 558947, because you can never have too tangled a bugball.