580522 - Need a user-visible pref to disable Aero Peek

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Rob Arnold [:robarnold]]

There's enough negative feedback on input.mozilla.org that suggests we should have a GUI option for it (I am not convinced there exists a behavior suitable for all users). Also, Opera and IE have a GUI pref.

Note that browser.taskbar.previews.enable already works and is a live pref so hopefully this is a really easy fix.

Comment 1

[Rob Arnold [:robarnold]]

Attachment: Add pref to tabs tab

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 461069 [details] [diff] [review]
Add pref to tabs tab

>diff --git a/browser/components/preferences/tabs.js b/browser/components/preferences/tabs.js

>+   * This is currently only run on Windows.

>+  init: function () {

get rid of the comment in favor of ifdeffing the entire function as well?

You need ui-review on this.

Comment 3

[Rob Arnold [:robarnold]]

Attachment: Add pref to tabs tab v2

Nix'd the comment in favor of more #ifdef love.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 461087 [details] [diff] [review]
Add pref to tabs tab v2

Maybe "Show tab previews in the Windows taskbar"?

Comment 5

[Rob Arnold [:robarnold]]

Attachment: Add pref to tabs tab v3

Done.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 461475 [details] [diff] [review]
Add pref to tabs tab v3

ui-r+a=beltzner, though I reserve the right to want to remove the word "Windows" at some later date! :)

Comment 7

[Rob Arnold [:robarnold]]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/0a469738e2fb

Comment 8

[pal-moz]

Attachment: screenshot

only active tab's preview is still shown.

uncheck means "don't show tab previews".
so active tab's preview should not be shown ?

Comment 9

[Rob Arnold [:robarnold]]

(In reply to comment #8)
> Created attachment 461718 [details]
> screenshot
> 
> only active tab's preview is still shown.
> 
> uncheck means "don't show tab previews".
> so active tab's preview should not be shown ?

The default behavior in Windows is to show the contents of the window so you would see the active tab plus the browser ui (the thumbnail shows the UI if you look carefully). When unchecked, this is the behavior you will get. I think there may be settings in Windows to give you the taskbar behavior from previous versions of Windows if you really want it.

Comment 10

[pal-moz]

nothing to do with Windows default.

point is "Show tab previews in the Windows taskbar"
uncheck this means "don't show previews", "disable tab previews"
maybe many users think like this.

if active tabs's preview is show, this sentence should be re-write to correspond to actual behavior ?