580893 - Wrong display of buttons in the survey page with long labels

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of the buttons

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

When labels used for these buttons are too long, the character » is displayed on the left of the button glyph.

I need to check this also on other platforms to see if it's only a Mac problem.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Screenshot of Test Pilot Survey (buttons) on Windows XP

Ever worst on Windows XP

Comment 2

[Marcia Knous [:marcia]]

Flod: Which version of test pilot are you using?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to comment #2)
> Flod: Which version of test pilot are you using?

Version 1.0 (built-in in b2)

Comment 4

[Andres Hernandez [:andreshm]]

Attachment: proposed patch

I'm using width 310px, but it still can be a bit longer if needed.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to comment #4)
> I'm using width 310px, but it still can be a bit longer if needed.

How can we test it?

Comment 6

[Jono Xia]

Andres: I'm concerned that any width we hard-code into the page layout will be too wide for some languages, too narrow for others.  Can we instead allow the width to be determined dynamically based on the width of the contents?

Thanks.

Comment 7

[Jono Xia]

Flod:  To test this (or any patch), you'll have to be running Test Pilot from an Hg checkout (instructions here: https://wiki.mozilla.org/Labs/Test_Pilot/debug ) Then save the proposed patch as a "patch.diff" file, and do

hg import patch.diff

you may have to enter an Hg commit comment; just enter whatever.  Then restart Firefox and you should see the changes applied.

Comment 8

[Andres Hernandez [:andreshm]]

Attachment: proposed patch 2

Removed the width value, the box now grow according to the label width.

Comment 9

[Tracy Walker [:tracy]]

This is the kind of thing (odd layout) QA just knows to look out for during manual testing.  Not going to write a specific litmus test cases for it. Probably not easily automated either.

Comment 10

[Jono Xia]

Applied Andres' patch in http://hg.mozilla.org/labs/testpilot/rev/ff3a940ce3cd and verified that it works as intended.

Comment 11

[Tracy Walker [:tracy]]

verified with recent build of TP

Comment 12

[Jono Xia]

Attachment: Patch for this and bug 594164, combined

This patch fixes this bug as well as bug 594164.

Comment 13

[Dave Townsend [:mossop]]

Landed in mozilla-central: http://hg.mozilla.org/mozilla-central/rev/edf04cd3cca0