581227 - |warning: memset used with constant zero length parameter| when linking libvpx (extend.c)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Justin Lebar (not reading bugmail)]

I get the following linker warning in libvpx:

/usr/bin/ld.gold.real: ../../staticlib/components/libgklayout.a(extend.o): in function T.0:/usr/include/bits/string3.h:83: warning: memset used with constant zero length parameter; this could be due to transposed parameters

I'll bring this up upstream, but in the meantime, we can hide the scary warning with a simple patch.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 2

[Justin Lebar (not reading bugmail)]

Alternatively, we could delete the offending memset altogether.  This might be safer on a compiler which doesn't recognize that el is always 0.

Comment 3

[Justin Lebar (not reading bugmail)]

Filed upstream: http://code.google.com/p/webm/issues/detail?id=150

Comment 4

[Timothy B. Terriberry (:derf)]

Comment on attachment 459650 [details] [diff] [review]
Patch v1

A separate patch file that applies this change to a vanilla libvpx from upstream needs to be created and added to media/libvpx/update.sh, so that the library can be updated by following our procedure in https://wiki.mozilla.org/WebM/Updating_libvpx

You should coordinate with upstream as to the best approach: either ask in #vp8 on freenode, on the codec-devel mailing list (http://www.webmproject.org/about/discuss/), or file a bug (http://www.webmproject.org/code/bug-reporting/).

Comment 5

[Justin Lebar (not reading bugmail)]

Fixed upstream (change 1d8277f8e).

I think we might as well pick it up next time we sync with libvpx -- there's little value in adding yet another patch.

derf, should we keep this bug open until the next sync with libvpx?

Comment 6

[Timothy B. Terriberry (:derf)]

That sounds reasonable to me.

Comment 7

[Timothy B. Terriberry (:derf)]

Fixed by bug 593753.