Closed Bug 581227 Opened 10 years ago Closed 10 years ago
|warning: memset used with constant zero length parameter| when linking libvpx (extend
I get the following linker warning in libvpx: /usr/bin/ld.gold.real: ../../staticlib/components/libgklayout.a(extend.o): in function T.0:/usr/include/bits/string3.h:83: warning: memset used with constant zero length parameter; this could be due to transposed parameters I'll bring this up upstream, but in the meantime, we can hide the scary warning with a simple patch.
Assignee: nobody → justin.lebar+bug
Status: NEW → ASSIGNED
Attachment #459650 - Flags: review?(tterribe)
Alternatively, we could delete the offending memset altogether. This might be safer on a compiler which doesn't recognize that el is always 0.
Filed upstream: http://code.google.com/p/webm/issues/detail?id=150
Comment on attachment 459650 [details] [diff] [review] Patch v1 A separate patch file that applies this change to a vanilla libvpx from upstream needs to be created and added to media/libvpx/update.sh, so that the library can be updated by following our procedure in https://wiki.mozilla.org/WebM/Updating_libvpx You should coordinate with upstream as to the best approach: either ask in #vp8 on freenode, on the codec-devel mailing list (http://www.webmproject.org/about/discuss/), or file a bug (http://www.webmproject.org/code/bug-reporting/).
Attachment #459650 - Flags: review?(tterribe) → review-
Fixed upstream (change 1d8277f8e). I think we might as well pick it up next time we sync with libvpx -- there's little value in adding yet another patch. derf, should we keep this bug open until the next sync with libvpx?
That sounds reasonable to me.
Fixed by bug 593753.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.