Closed Bug 593753 Opened 9 years ago Closed 9 years ago

Update libvpx to 0.9.2

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: derf, Assigned: derf)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch Patch to update to libvpx 0.9.2 (obsolete) — Splinter Review
libvpx 0.9.2 was recently released: http://webm.googlecode.com/files/libvpx-v0.9.2.tar.bz2
This release resolves several outstanding issues and improves VP8 decoding performance.
Attachment #472330 - Attachment is patch: true
Attachment #472330 - Attachment mime type: application/octet-stream → text/plain
Attachment #472330 - Attachment is patch: true
Attachment #472330 - Attachment mime type: application/octet-stream → text/plain
Blocks: 584253
Blocks: 569812, 571141, 581227
OS: Linux → All
Hardware: x86_64 → All
Some of the new assembly (specifically vp8/common/x86/idctllm_sse2.asm) does not compile using the old yasm2masm script, apparently because many of the memory operands do not have explicit size prefixes and masm always assumes a 32-bit size, even when that makes no sense in combination with the current opcode (e.g., pinsrw or movq, which seem to be most of the offenders).

My original patch also did not update the HIDDEN_DATA directive, which is required, since the upstream approach to fixing bug 572876 differed in syntax slightly from ours.

We could keep trying to extend the yasm2masm script, but I think the better long-term approach is to land bug 583849, so I've made that block this one.
Depends on: 583849
Attachment #472330 - Flags: review?(chris)
Apparently following the update instructions on a 64-bit Linux machine gets the architecture wrong for the x86-linux-gcc target. Updated patch to fix this.
Attachment #472330 - Attachment is obsolete: true
Attachment #472512 - Flags: review?(chris)
Attachment #472330 - Flags: review?(chris)
Comment on attachment 472512 [details] [diff] [review]
Patch to update to libvpx 0.9.2

Looks good. Builds on everything we build with on TryServer.

(In reply to comment #2)
> Apparently following the update instructions on a 64-bit Linux machine gets the
> architecture wrong for the x86-linux-gcc target. Updated patch to fix this.

Can you the update the instructions wiki page to prevent this in future? Thanks.
Attachment #472512 - Flags: review?(chris) → review+
I've updated the page (https://wiki.mozilla.org/WebM/Updating_libvpx, for reference).
Keywords: checkin-needed
Assignee: nobody → tterribe
http://hg.mozilla.org/mozilla-central/rev/012c64c66def
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Attached patch fix for SolarisSplinter Review
now they're using "static __inline"
Attachment #473909 - Flags: review?(tterribe)
Every __inline function in that file is already declared static.
Timonthy,

That's exactly why I need to change
#define __inline static inline
to
#define __inline inline

for Sun Studio compiler.

(In reply to comment #7)
> Every __inline function in that file is already declared static.
Ah, my mistake. I read the patch backwards.
Timothy, can I assume you gave r+ for the patch?
Comment on attachment 473909 [details] [diff] [review]
fix for Solaris

Yes, sorry, r+
Attachment #473909 - Flags: review?(tterribe) → review+
Solaris bustage patch committed:
http://hg.mozilla.org/mozilla-central/rev/d45c87e58110
You need to log in before you can comment on or make changes to this bug.