593753 - Update libvpx to 0.9.2

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Timothy B. Terriberry (:derf)]

Attachment: Patch to update to libvpx 0.9.2

libvpx 0.9.2 was recently released: http://webm.googlecode.com/files/libvpx-v0.9.2.tar.bz2
This release resolves several outstanding issues and improves VP8 decoding performance.

Comment 1

[Timothy B. Terriberry (:derf)]

Some of the new assembly (specifically vp8/common/x86/idctllm_sse2.asm) does not compile using the old yasm2masm script, apparently because many of the memory operands do not have explicit size prefixes and masm always assumes a 32-bit size, even when that makes no sense in combination with the current opcode (e.g., pinsrw or movq, which seem to be most of the offenders).

My original patch also did not update the HIDDEN_DATA directive, which is required, since the upstream approach to fixing bug 572876 differed in syntax slightly from ours.

We could keep trying to extend the yasm2masm script, but I think the better long-term approach is to land bug 583849, so I've made that block this one.

Comment 2

[Timothy B. Terriberry (:derf)]

Attachment: Patch to update to libvpx 0.9.2

Apparently following the update instructions on a 64-bit Linux machine gets the architecture wrong for the x86-linux-gcc target. Updated patch to fix this.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 472512 [details] [diff] [review]
Patch to update to libvpx 0.9.2

Looks good. Builds on everything we build with on TryServer.

(In reply to comment #2)
> Apparently following the update instructions on a 64-bit Linux machine gets the
> architecture wrong for the x86-linux-gcc target. Updated patch to fix this.

Can you the update the instructions wiki page to prevent this in future? Thanks.

Comment 4

[Timothy B. Terriberry (:derf)]

I've updated the page (https://wiki.mozilla.org/WebM/Updating_libvpx, for reference).

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/012c64c66def

Comment 6

[Ginn Chen]

Attachment: fix for Solaris

now they're using "static __inline"

Comment 7

[Timothy B. Terriberry (:derf)]

Every __inline function in that file is already declared static.

Comment 8

[Ginn Chen]

Timonthy,

That's exactly why I need to change
#define __inline static inline
to
#define __inline inline

for Sun Studio compiler.

(In reply to comment #7)
> Every __inline function in that file is already declared static.

Comment 9

[Timothy B. Terriberry (:derf)]

Ah, my mistake. I read the patch backwards.

Comment 10

[Ginn Chen]

Timothy, can I assume you gave r+ for the patch?

Comment 11

[Timothy B. Terriberry (:derf)]

Comment on attachment 473909 [details] [diff] [review]
fix for Solaris

Yes, sorry, r+

Comment 12

[Ginn Chen]

Solaris bustage patch committed:
http://hg.mozilla.org/mozilla-central/rev/d45c87e58110