58141 - string w/ spaces was sent to DNS, then Domain Guessing

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect, P3)

Description

[Moses Lei]

In Netscape 4.x, typing "go mozilla browser" would use the search engine
specified in preferences to run a search on "mozilla browser." This doesn't work
in Mozilla, you must type "mozilla" in the URL box and click search.

Steps to reproduce:
type "go mozilla browser" in the URL box.

Expected result:
A search is run on "mozilla browser."

Actual result:
DNS lookup on "www.go mozilla browser.com" results, and brings up an error.

This is 4xp.

Build 2000101908 windows and linux.

Comment 1

[Blake Ross]

confirmed, ->xpapps, me

Comment 2

[Blake Ross]

need to figure out what's going on

Comment 3

[Blake Ross]

OK, good news.  This is just a problem with the pref itself, not the keyword 
protocol handling.

Comment 4

[Blake Ross]

Wait.  There isn't even a problem here.  Turn on Internet Keywords in your 
Smart Browsing prefs and you're good to go.  Marking INVALID, but please reopen 
if you think internet keywords should be on by default.

Comment 5

[Blake Ross]

More spam...

I think they should be.  Reopening this bug to make internet keywords be on by 
default, but making this lower priority.

Comment 6

[Moses Lei]

Agreed. Also, the "More information" button doesn't work, it just takes you to
mozilla.org . Should that be a separate bug? (or is one already filed for it)

"Internet Keywords" is a term that needs to be explained better in the dialog.
It only says what it can do ("enables fast access to services such as stock
quotes, search" etc.) but not how to do it ("go keyword").  In fact, I don't
know what other keywords there are besides "go."

Marking 4xp again because this functionality is on by default in NS 4.x.

Should this be relnoted for the next milestone?

Comment 7

[Blake Ross]

Attachment: [patch] turn keywords on by default

Comment 8

[Blake Ross]

cc jag/alec for r/sr of this monster

Comment 9

[Alec Flett]

yay! I always wondered why this wasn't on in mozilla builds...sr=alecf

Comment 10

[Blake Ross]

Fix checked in.

Comment 11

[benc]

+verifyme, qa to me.
From looking at this, the pref was off, and it was a DNS problem, so I'm taking it.

I'll tackle verification when I return.

NOTE: IK is off by default now (see bug 100412).

The documentation problem has been fixed with an interim document, and I've got
an even better version in the cooker, see bug Bug 63317.

Comment 12

[benc]

REOPEN:
Hmm, if you turn internet keywords off, the problem persists. 

Anyone want to describe what the behavior should be if IK==OFF and someone types
in a space-delimited string?

Comment 13

[Bartosz Wucke]

I think leading and trailing spaces should be stripped. (to make c&p easier,
i.e. after selecting whole line.) and whatever's left be parsed as URL.
IMHO, if there appears the "Search [your search engine] for..." as you type, 
there's no need for forcing "internet keywords" on user who deliberately turned
them off.
My options:
Behavior 1: Display requester "Invalid URL. Illegal characters used in URL. [Try
anyway] [Cancel] [Search using Internet Keywords]"
Behavior 2: Convert spaces to %20 and go on with parsing as URL.
Behavior 3. Treat separate "words" as separate URLs to be opened in different
tabs/windows. In one hand, would be neat to open several windows at once this
way, but in the other, if someone accidentially pastes a screenful of text into
URL field - ouch! Put some limits?
Behavior 4: (current) Convert spaces to dots, add www and com and parse as url.

Comment 14

[benc]

-> URL bar 

This can probably marked fixed...

1- a change in URL bar recently made searches for "cats and dogs" error now, w/
invalid protocol, if IK is off. I don't know which bug made that change, so I
can't dupe of mark fixed myself.

2- I haven't checked how this works in non-URL bar stuff like links, but I will
eventually.

Comment 15

[benc]

URL bar and docshell have fixes that cause this to error as an invalid protocol.
I don't know which checkin fixed this, so I'm leaving it to the experts.

Comment 16

[benc]

If Internet Keywords is off, strings w/ spaces now error, which is the correct
behavior.