58145 - valign attribute ignored in XUL (boxes)

Status: RESOLVED INVALID

(Core :: XUL, defect, P3)

Description

[Robert Kaiser]

Doing skin work, I saw that the valign attribute is set in lots of XUL files
(almost everywhere set as valign="middle") but it seems that moz does simply
ignore it.
It's also used a lot in XBL, e.g. status bar layout is harmed by it, as
statusbar-panel has this in its declaration:
  <binding id="statusbar-panel" extends="xul:button">
    <content autostretch="never" valign="middle">

and then e.g. status bar text display is set like that:
<statusbarpanel id="statusbar-display" value="&statusText.label;" crop="right"
flex="1"/>
this one is shown on top of the sidebar panel, and not vertically in the middle.

The same is true for sidebar-header for example: the text "My Sidebar" should be
in the middle of sidebar header - but it's actually aligned to the top.

Comment 1

[Robert Kaiser]

it gets more interesting: vertical-align CSS attribute does work on those elements!

Comment 2

[Blake Ross]

If this is indeed true it would explain the misalignment of the sidebar 
headers, as Robert mentions, which would solve a great mystery...and it 
probably should be fixed for rtm, since valign is used in many places in the 
app. Maybe hyatt can shed some light...

Comment 3

[Peter Trudelle]

->evaughan

Comment 4

[Peter Trudelle]

rtm-/future. No indication this is causing any significant specific defects in N6.

Comment 5

[Eric Vaughan]

valign does work. Try this examle:

<?xml version="1.0"?>
<?xml-stylesheet href="chrome://global/skin/" type="text/css"?>

<!DOCTYPE window>

<window orient="vertical"
xmlns:html="http://www.w3.org/TR/REC-html40"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

	<hbox flex="1" autostretch="never" style="text-align: center" valign="middle">
		 <button value="foo"/>
	</hbox>


</window>

But I think there is a bug in XBL. It does not set attributes correctly. It
should set all attributes on live content nodes after reflow (There is a funtion
on the presShell to do this). Otherwise the frame is never notified.

Off to hyatt.

Comment 6

[Robert Kaiser]

Hmm, what's staus here? RTM is over, future had been assinged when not really
knowing what's happening here...

Hyatt, I still see this happening, any comment?

Comment 7

[Blake Ross]

Robert, are you still seeing this?  Bug 54795 (which this is thought to have 
caused) is now working.

Comment 8

[Thomas]

No action since comment #6 and #7, this makes almost 4 years no action.
Does this validate for wontfix?

Comment 9

[Benjamin Smedberg]

valign is not part of the XUL grammar, mozilla chrome examples be damned. Use
align/pack.