Closed Bug 581475 Opened 9 years ago Closed 9 years ago
Context Menu cleanup
- bails out early if the menu isn't going to be displayed - removes the unused aXulMenu argument - removes the duplicate property initialization I've pushed this and the patch in bug 425575 to the tryserver, tests pass.
Attachment #459855 - Flags: review?(mano)
Comment on attachment 459855 [details] [diff] [review] patch r=mano
Attachment #459855 - Flags: review?(mano) → review+
Comment on attachment 459855 [details] [diff] [review] patch Is nsContextMenu an API that extensions might be using?
Yes, extensions might. Should the menu parameter be kept?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
Looks like all existing tests pass with this change. Marking as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.