Closed Bug 581475 Opened 15 years ago Closed 15 years ago

nsContextMenu cleanup

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b3

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(2 files)

patch
13.57 KB, patch
asaf
: review+
Details | Diff | Splinter Review
without the parameter removal
6.95 KB, patch
benjamin
: approval2.0+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review
- bails out early if the menu isn't going to be displayed - removes the unused aXulMenu argument - removes the duplicate property initialization I've pushed this and the patch in bug 425575 to the tryserver, tests pass.
Attachment #459855 - Flags: review?(mano)
Comment on attachment 459855 [details] [diff] [review] patch r=mano
Attachment #459855 - Flags: review?(mano) → review+
Attachment #459855 - Flags: approval2.0?
Comment on attachment 459855 [details] [diff] [review] patch Is nsContextMenu an API that extensions might be using?
Yes, extensions might. Should the menu parameter be kept?
Maybe: our mozilla2.0 API rules (draft at https://developer.mozilla.org/En/Developer_Guide/Interface_Compatibility#JavaScript.2fXUL_Interfaces) If retaining compatibility is simply keeping the extra unused parameter, we probably should.
Attachment #461262 - Flags: approval2.0?
Attachment #459855 - Flags: approval2.0?
Attachment #461262 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/5b189034696e
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
Looks like all existing tests pass with this change. Marking as verified fixed.
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
Blocks: 655863
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: