58148 - filling in forms uses to much cpu

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P2)

Description

[felix hudson]

when filling in this form whenever i type a key my cpu usage hits 100%
( i have 0% when i am not typing). and the text feed back is sluggy.
moving left and right through the typed text is quick, but adding or removing is
very slow.

Comment 1

[Jerry Baker]

On my 800MHz, typing in form fields eats 10% cpu. This is a little too much 
IMHO. Tested with 2000102905 trunk bits on Windows 2000.

Changing component to form controls.

Comment 2

[rods (gone)]

probably a dup - reassigning

Comment 3

[kinmoz]

This probably has something to do with the fact that the textareas and texfields
in bugzilla forms are in tables. We seem to be redrawing and maybe even
reflowing everything below the text widget you are typing in when it is in a table.

Buster should this go to you? Also, this may be a dup of a bug anthonyd was
looking at sometime last week.

Comment 4

[buster]

I'll take a look.  I thought we fixed something similar already, maybe this is
just a case we missed.

Comment 5

[kinmoz]

Reassigning to [e-mail] while he investigates.

Comment 6

[buster]

The primary culprit here is a chunk of code that marks every line in a block
"dirty" in some circumstances, including incremental reflow within a text control.
I have a band-aid for text controls, and I'll submit another bug on what really
should be done.

Comment 7

[buster]

Attachment: patch that greatly reduces the amount of reflow/repaint during typing in a text field

Comment 8

[buster]

Kevin:  I just attached a patch that improves the problem we discussed earlier
today.  It helps the test case mentioned in this bug a lot, and should help
quite a bit with the similar problems you've seen that the patch for bug 47549
uncovered.

Comment 9

[Chris Waterson]

taking

Comment 10

[Chris Waterson]

End-of-milestone reality check.

Comment 11

[Chris Waterson]

Is there a test case? I'm not seeing any real CPU usage when typing into text
fields, and although the patch looks okay, I'd like to verify that it does
_something_....

Comment 12

[kinmoz]

Perhaps they were using:

    http://bugzilla.mozilla.org/enter_bug.cgi?product=Browser

Comment 13

[Simon Fraser [no longer active]]

*** Bug 62549 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Waterson]

I think that there may be a better (more general) approach to fixing this in bug 
43914. Let me poke at that for a bit, and if I can't make any headway, we'll 
check this bad boy in.

Comment 15

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 16

[Matthias Versen [:Matti]]

*** Bug 134653 has been marked as a duplicate of this bug. ***

Comment 17

[Chris Waterson]

This ought to be fixed with the changes from bug 135146.

Comment 18

[Jerry Baker]

Mass removing self from CC list.

Comment 19

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.