581508 - Implement nsIUserInfo on Win32, particularly fullname

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Ben Bucksch (:BenB)]

nsIUserInfo.fullname gives error "not implemented" on Win32, see
<http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/startup/src/nsUserInfoWin.cpp>.

I'd be useful for e.g. bug 29593.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch for implementation of nsIUserInfo

If you don't have your full name filled out it will return NS_ERROR_NOT_AVAILABLE.  If there is any other type of error it will return NS_ERROR_FAILURE.

If you don't have your full name filled out, you can fill it in by following these steps if you are not part of a domain:

1) Go to Control Panel\System and Security\Administrative Tools
2) Open Computer Management
3) Expand Local Users and Groups on the left
4) Click on Users on the left
5) Double click on your username on the right

If you are part of a domain you will need to use Active Directory on the domain controller.

Comment 2

[Brian R. Bondy [:bbondy]]

Everything used by the way, I believe, is supported on Windows 2000 and up which I think is our minimum supported version.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 556417 [details] [diff] [review]
Patch for implementation of nsIUserInfo

Moving review request because rs has a bunch of silent software update reviews from me which are higher priority than this task.

Comment 4

[Brian R. Bondy [:bbondy]]

Comment on attachment 556417 [details] [diff] [review]
Patch for implementation of nsIUserInfo

Robert Strong mentioned that you could do this review Jim. (No rush this is pretty low priority)

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 556417 [details] [diff] [review]
Patch for implementation of nsIUserInfo

grabbing this info feels a little creepy. I hope we are treating it appropriately!

Comment 6

[Brian R. Bondy [:bbondy]]

I think the intent is to use it for Thunderbird when composing new emails on Windows.

Pushed to try: 
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=97bc44057367

Comment 7

[Brian R. Bondy [:bbondy]]

Try results look good, but before I push this I just need to setup a mingw build environment first and test a build.

Comment 8

[Ben Bucksch (:BenB)]

Thanks, Brian, for the work. Appreciated.

Is a Windows 7 user, when buying a pre-installed notebook, prompted to enter his name when using the computer the first time? (What about Windows XP, used by 40%? Windows 7 is now the majority, though.)

Comment 9

[Brian R. Bondy [:bbondy]]

> Is a Windows 7 user, when buying a pre-installed notebook, prompted to enter his name when using the computer the first time? (What about Windows XP, used by 40%? Windows 7 is now the majority, though.)

Sorry I don't know the answer to that question.

Comment 10

[Ben Bucksch (:BenB)]

> -        LIBS="$LIBS -luuid -lgdi32 -lwinmm -lwsock32"
> +        LIBS="$LIBS -luuid -lgdi32 -lwinmm -lwsock32 -lsecur32 -lnetapi32"

Is it possible to make an autoconfig test for this, set an #define when found, and only then add the dependencies, and protect the C++ code with that define? Or are these deps uncritical (any supported Windows would have them)?

Comment 11

[Brian R. Bondy [:bbondy]]

Should be supported by all since Windows 2000 and up, just want to try with mingw to be sure though.

I have another task I need to get mingw up for anyway so might as well do this at the same time.

Comment 12

[Brian R. Bondy [:bbondy]]

Do we still want this patch? If not we should WONTFIX this bug. 
Just cleaning up some old bugs in my list.

Comment 13

[Ben Bucksch (:BenB)]

yes. Seems like the patch is fine, has review, and ready for commit.

Comment 14

[Brian R. Bondy [:bbondy]]

OK thanks. I'm not sure if it ever ran through try so I'll do that now and then I'll push it myself.   I never did get mingw builds to work to try it out, but if it doesn't we can fix that in a follow-up once someone complains.

Comment 15

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

- Rebased patch to m-c tip
- Changed to newer mozilla::ArrayLength form NS_ARRAY_LENGTH
- Added NS_ENSURE_ARG_POINTER to the start of every function

Carrying forward r+.
Pushed to try, will push to mozilla-inbound if that succeeds.

Comment 16

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8ee857e02861

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8ee857e02861

Comment 18

[Ben Bucksch (:BenB)]

Thanks, everybody!