581726 - [Win7] Aero-Peek issue with Navigation Bar redrawing when TabCandy is displayed

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[locke105]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100723 Minefield/4.0b3pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100723 Minefield/4.0b3pre (.NET CLR 3.5.30729)

Found this issue when I opened the TabCandy viewer and then was using the AeroPeek fuctionality of Win7.

The navigation bar is rendering the top of the TabCandy view while the Aero-peek is rendering the actual FireFox tab display.

I have a picture to attach that shows what happens.

Reproducible: Always

Steps to Reproduce:
1. Open TabCandy viewer
2. Hover over Firefox task in taskbar
3. Observe
Actual Results:  
Navigation bar appears as top of TabCandy

Comment 1

[locke105]

Attachment: display issue screen capture

Comment 2

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 3

[juan becerra [:juanb]]

This is still a problem in the latest 4.0b5pre (20100827). One more Windows 7 aero peek problem.

Comment 4

[Ian Gilman [:iangilman]]

We expect bug 605338 to land before FF4.0, and bug 586155 after FF4.0, so punting this to the future.

Comment 5

[Kevin Hanes]

Moving this back to our current work list as Aero Peek will most likely remain on by default and available in general. See comments 4 and 5 in bug 608338 for more info as to why.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> Moving this back to our current work list as Aero Peek will most likely remain
> on by default and available in general. See comments 4 and 5 in bug 608338 for
> more info as to why.

I'm working on some changes to the default behavior in bug 522035 which may make this problem simpler to solve. (assuming it works and gets approved.)

Comment 7

[Jim Mathies [:jimm]]

I've posted a simple patch in bug 538487 for print preview that turns tab previews off when the print preview comes up. This might be useful here. I didn't see an event tied to tab candy hide/show that I could hook up to, but I imagine it would be easy to add something like that.

Comment 8

[Ian Gilman [:iangilman]]

(In reply to comment #7)
> I've posted a simple patch in bug 538487 for print preview that turns tab
> previews off when the print preview comes up. This might be useful here. I
> didn't see an event tied to tab candy hide/show that I could hook up to, but I
> imagine it would be easy to add something like that.

Cool! Panorama sends out "tabviewhidden" and "tabviewshown" events when the Panorama UI is hidden or shown, respectively.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

We don't need to block on this if we continue to block on bug 605338

Comment 10

[Jim Mathies [:jimm]]

I have a patch for this in my queue. just waiting on bug 538487 to settle.

Comment 11

[Jim Mathies [:jimm]]

Attachment: fix v.1

Comment 12

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 13

[Kevin Hanes]

bugspam (removing b9)

Comment 14

[Michael Yoshitaka Erlewine [:mitcho]]

I want to punt this, as we've done with Aero Peek integration in general, but this seems particularly jarring. Dao, could you review this, or could you change the review flag to someone else?

Comment 15

[Michael Yoshitaka Erlewine [:mitcho]]

Nevermind... Aero Peek is disabled by default for fx4 (bug 605338) so we'll punt on this.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 497817 [details] [diff] [review]
fix v.1

a=beltzner

Comment 17

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/953be21166fe

Comment 18

[George Carstoiu]

Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110215 Firefox/4.0b12pre

Issue was verified and it's no longer reproducible.