582200 - give tabcandy a spot cleaning

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch (clean up /core/utils.js and /core/iq.js)

Remove IE, Safari, and Netscape 4 compatibility code. :D

Other assorted bits.

CSS style nit cleanup.

Comment 1

[Frank Yan (:fryn)]

Attachment: patch (clean up /tabcandy.css)

made the style consistent.

came across this:

.favicon {
  width: 17;
  height: 17;
}

https://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/file/7521f4782eef/browser/base/content/tabcandy/tabcandy.css#l72

I added px to each of those, but I'm not sure if that actually broke anything, so you might want to double-click. :)

Comment 2

[Ed Lee :Mardak]

Do you have more patches incoming? In particular for iq or utils? We're in the process of getting it reviewed and would like it as stable as we can get for now.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 460495 [details] [diff] [review]
patch (clean up /core/utils.js and /core/iq.js)

(In reply to comment #0)
> Created attachment 460495 [details] [diff] [review]
> patch (clean up /core/utils.js and /core/iq.js)
> 
> Remove IE, Safari, and Netscape 4 compatibility code. :D
> 
> Other assorted bits.
> 
> CSS style nit cleanup.

Thanks Frank. Accepted.

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/6091d71c7222

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Comment on attachment 460497 [details] [diff] [review]
patch (clean up /tabcandy.css)

Accepted. Thanks Frank.

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/bfe28992d0ca

I made a little mistake with the commit message, but I think people will get the idea. ;)

Comment 5

[Aza Raskin [:aza]]

Thanks, Frank!

Comment 6

[Frank Yan (:fryn)]

> I added px to each of those, but I'm not sure if that actually broke anything,
> so you might want to double-click. :)
s/double-click/double-check/

(In reply to comment #4)
> Comment on attachment 460497 [details] [diff] [review]
> patch (clean up /tabcandy.css)
> 
> Accepted. Thanks Frank.
> 
> http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/bfe28992d0ca
> 
> I made a little mistake with the commit message, but I think people will get
> the idea. ;)

I'm now part of TabCandy! Im in yr br0wz0rz, sweetening your tabs :P

Comment 7

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".