582455 - Remove the grippy from the Web Console

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

The image on the grippy on the Web Console is currently overlaid on top of the knob, which looks strange on Mac and Windows. Also, the cursor changes to the "hand" cursor while over the grippy, which is, IMHO, less appropriate than the "ns-resize" cursor.

The attached patch fixes these issues. It touches only the CSS.

Because this is a serious UI issue that could confuse users, I'd like to request that it block the Firefox 4 release.

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 460716 [details] [diff] [review]
Proposed patch.

Sounds like you really want to just take out the grippy instead of covering up its effects. cf the (grippy-less) splitters in the Page Info dialog, the one used for the sidebars, the one in Library, etc.. Grippies aren't really used in Firefox. In fact, after a quick search on MXR, it seems grippies aren't used in mozilla-central *at all*.

Comment 2

[David Dahl :ddahl]

(In reply to comment #1)
>  Grippies aren't really used in
> Firefox. In fact, after a quick search on MXR, it seems grippies aren't used in
> mozilla-central *at all*.

wow. who knew?

Comment 3

[Philip Chee]

> In fact, after a quick search on MXR, it seems grippies aren't used in
> mozilla-central *at all*.

Did you check comm-central as well? :D
http://mxr.mozilla.org/comm-central/search?string=grippy&find=\.xul

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to comment #3)
> Did you check comm-central as well? :D
> http://mxr.mozilla.org/comm-central/search?string=grippy&find=\.xul

I'm aware that SeaMonkey uses them quit a bit, but the code in question is also m-c.  Although, if this is going to see reuse in SeaMonkey, it might be appropriate to use a grippy and use a rule in the Firefox skin to make it "display: none;", which effectively amounts to "tak[ing] it out" there.

Comment 5

[Philip Chee]

I'm joking. By all means take it out since Firefox will be the primary consumer. I'm sure we'll somehow manage.

Comment 6

[Patrick Walton (:pcwalton)]

Attachment: [checked-in] Proposed patch, version 2.

New patch removes the grippy.

This causes a regression in that the splitter can no longer be double-clicked in order to collapse it. However, based on what I gathered from ddahl, the collapsing behavior was never considered to be final. Patches to enable more sensible collapsing behavior are forthcoming, and will be linked to from this bug.

Comment 7

[David Dahl :ddahl]

Comment on attachment 460940 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

yeah! a patch with removal only!

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 460940 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

http://hg.mozilla.org/mozilla-central/rev/3c512fbfd912