quick filter state on folder switch involving Account central does not match button state

RESOLVED FIXED in Thunderbird 10.0

Status

RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: bc6xv001, Assigned: iagosrl)

Tracking

({student-project})

unspecified
Thunderbird 10.0
x86
Windows XP
student-project

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1

If you have a quick filter selected for a folder, then select a "main" folder ("Local Folders"), then switch back to the original, the button for the quick filter stays depressed, but the filter is not applied.

Reproducible: Always

Steps to Reproduce:
1. Select the Inbox in an account folder.  
2. Apply the "Unread" quick filter by pressing the button.  
3. Select any account folder (e.g.  "Local Folders" ) (not a folder of the account -- the actual bold account folder)
4. Select the same Inbox you selected in Step 1.
Actual Results:  
The unread quick filter button stays selected (regardless of pin state), but the filter is not actually applied (i.e. the folder shows all the messages, not just the unread ones)

Expected Results:  
Depends on pin state.  If pin selected, unread filter should be applied.

If the pin is not selected, the quick filter button state should have been reset to off.

Seems to work as expected when you select another mail folder instead of an account folder.  Also works as expected when, in step 4, you select a different mail folder instead of the original mail folder.

Bug also appears on the Mac version.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: quick filter state on folder switch does not match button state → quick filter state on folder switch involving Account central does not match button state
Excellent bug report, thank you.
Keywords: student-project
(Assignee)

Comment 2

7 years ago
Created attachment 564348 [details]
File with purposed bugfix

Hi,
 I'm working in an extension that works with the filtering capabilities of Thunderbird called "Unified Search", I found this bug breaking my code and I did a bugfix from my extension, available from version 0.6.3 (https://addons.mozilla.org/en-US/developers/addon/unified-search-187593/versions/1272083) to try it.
 It works, after that I decide modify the original file to apply my bugfix and this is what I'm uploading here called quickFilterBar-fixed.js.
 Original file is located at omni.jar!/chrome/messenger/content/messenger/quickFilterBar.js
 I don't know if is the best solution, or the best code, but works. I expect that, if is not the valid code, almost help to find the best solution.
(Assignee)

Comment 3

7 years ago
Created attachment 564352 [details] [diff] [review]
Same proposed bugfix that previous file but in patch format

Patch over the previous complete file. The original file I used is from release 7.0.1.
(Assignee)

Comment 4

7 years ago
I forget to say the bug happens too in Linux (Ubuntu 11.04), with Thunderbird versions from 3.1 to 7.0.1.
Comment on attachment 564352 [details] [diff] [review]
Same proposed bugfix that previous file but in patch format

Setting the r? so that your patch can get reviewed.

Wondering if we need to also add a unit test.
Attachment #564352 - Flags: review?(dbienvenu)
Assignee: nobody → iagosrl
Status: NEW → ASSIGNED
Attachment #564348 - Attachment is obsolete: true

Comment 6

7 years ago
Comment on attachment 564352 [details] [diff] [review]
Same proposed bugfix that previous file but in patch format

this doesn't actually apply as a patch against our repo...I'll try to convert it into a patch.

Comment 7

7 years ago
Created attachment 567450 [details] [diff] [review]
in patch format
Attachment #564352 - Attachment is obsolete: true
Attachment #567450 - Flags: review?(dbienvenu)
Attachment #564352 - Flags: review?(dbienvenu)

Comment 8

7 years ago
Created attachment 567560 [details] [diff] [review]
tweaked patch

I tweaked the patch (edited the comments, shortened some lines, got rid of temp vars, etc) but the patch didn't fix the issue. I don't think I messed up the logic of the original patch, but it didn't work for me.
Attachment #567450 - Attachment is obsolete: true
Attachment #567560 - Flags: review?
Attachment #567450 - Flags: review?(dbienvenu)

Comment 9

7 years ago
Comment on attachment 567560 [details] [diff] [review]
tweaked patch

Robert, could you try my version of the patch against the trunk and see if it works for you? Thx!
Attachment #567560 - Flags: review? → review-
(Assignee)

Comment 10

7 years ago
Hi David,

 The logic of your last patch is correct but there is a small mistype (missed letter 'p' at aFolderDisplay) here:

if (!aFolderDislay.displayedFolder ||

Comment 11

7 years ago
Created attachment 567854 [details] [diff] [review]
cleaned up patch w/o typo

ah, thx much, that works. r+. I'll land this when I get a chance, and the tree is open...
Attachment #567560 - Attachment is obsolete: true
Attachment #567854 - Flags: review+

Updated

7 years ago
Keywords: checkin-needed
Committed as http://hg.mozilla.org/comm-central/rev/8bd40bb0d720
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.