582606 - Do not generate trends on every search

Status: RESOLVED FIXED

(Input Graveyard :: Search, defect, P3)

Description

[Fred Wenzel [:wenzel]]

Generating the trends box from scratch for every unique set of results is killing the slave every time we get serious traffic.

We need to change that. Options I can come up with on the fly are:
- remove the trends box
- collapse it by default, and only fetch it via AJAX on demand.

The latter won't remove the need for an expensive query, but it'll avoid running the query unless the user cares. We could even do the same thing for demographics -- that's not too cheap either.

CCing chowse so he can add his 2cts or even include it in his UX overhaul.

Comment 2

[Aakash Desai [:aakashd]]

The trends box on search queries is overloading the slave when we release a new
beta as it's not cached and people are finding way too many creative ways to
search.

I'd like to go with the same accordion style shown on our mobile pages for a quick workaround:

http://m.input.stage.mozilla.com/

except change the name from a noun to an action phrase.... 

"Trends" -> "Show Trends"

Comment 3

[Chris Howse [:chowse]]

Trending terms and domains are in collapsible sections in the redesign. I have no problem if content creation is deferred until the user expands the section.

Demographics are a bit trickier, since the same fields are now being used for filtering. If necessary, all (non-filtered) demographics can be collapsed by default and loaded on expansion. However, the fields (without stats) should appear immediately on expansion.

Comment 5

[Fred Wenzel [:wenzel]]

Demographics aren't a problem I think, but terms have been. They are cached on the front page and now hidden on the search results page.

Reducing priority for now, as this was an important performance bug, and now it is ("just") about bringing this feature back in a controlled manner.

Comment 6

[Fred Wenzel [:wenzel]]

Kicking this out of 1.7. Dave has some ideas on organizing our incoming feedback around a redis queue that would precalculate stuff for us outside a request-response loop. That's not a 1.7 topic, but will take care of this bug.

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

This was removed...