582678 - Dragging app tab behind normal tab should make it a normal tab and vice versa

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100727 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100727 Minefield/4.0b3pre

Long summary:
If you have an apptab open, dragging it behind a normal tab should make the apptab normal.
And dragging a normal tab in front of an apptab should turn it into an app tab.

Reproducible: Always

Comment 1

[J.P.Klippel]

Is this the same as 582807 / 582806?

Comment 2

[imradyurrad]

(In reply to comment #1)
> Is this the same as 582807 / 582806?

Yes. Mark them as duplicates of this.

Comment 5

[Dão Gottwald [:dao]]

Err, this doesn't really depend on bug 455694.

Comment 6

[imradyurrad]

(In reply to comment #5) > Err, this doesn't really depend on bug 455694.  

With the menubar disabled, the draw and drop arrow is cut off when you're dragging to the first tab. 
http://img193.imageshack.us/img193/8701/clipboard01cz.png

The UI's gonna look pretty jerky without the tab animations, so it'd be better to have bug 455694 land before this.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> With the menubar disabled, the draw and drop arrow is cut off when you're
> dragging to the first tab. 
> http://img193.imageshack.us/img193/8701/clipboard01cz.png

Right, so... this happens right now. It's orthogonal to transitioning tabs from/into app tabs with drag and drop.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f34e7fb56707