583022 - All calls to adb should be guarded against hanging

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Brent Baker]

We have seen a lot of 'adb' calls hang during the build testing process. All calls to execute the vm shell and abc files during acceptance running was addressed in bug# 576599, however we are occasionally seeing other 'adb shell' calls hang (mainly I have seen the 'adb shell chmod +x /data/app/avmshell' hang).

All calls to adb should be called via a killableprocess (python) so that it can be stopped and recalled if necessary.

Comment 1

[Brent Baker]

Attachment: replace all adb calls with adb_proxy.py calls

Replace all naked calls to adb with adb_proxy which calls adb via a killableprocess. This will timeout after ADB_TIMEOUT (env var) and will retry ABD_MAX_ATTEMPTS (env var) number of times.

Comment 2

[Trevor Baker]

Is there an android bug we can log regarding this intermittent behavior?

Comment 3

[Brent Baker]

Comment on attachment 461544 [details] [diff] [review]
replace all adb calls with adb_proxy.py calls

patch pushed as 4960:b9cbe2950dee

Comment 4

[Brent Baker]

Attachment: guard against trying to kill a process that has already completed

We have seen the following error happen in the build system, so guard against this error and just treat like a timeout and retry the call:

Traceback (most recent call last): 
File "platform/android/android_shell.py", line 85, in <module>
stdout=adb_proxy.main(["%s push %s /data/app/%s" % (adbargs,arg,flatfile)])
File "platform/android/adb_proxy.py", line 76, in main
p.wait(ADB_TIMEOUT)
File "platform/android/killableprocess.py", line 220, in wait
self.kill(group)
File "platform/android/killableprocess.py", line 177, in kill
os.killpg(self.pid, signal.SIGKILL)
OSError: [Errno 3] No such process

Comment 5

[Brent Baker]

Comment on attachment 480892 [details] [diff] [review]
guard against trying to kill a process that has already completed

patch pushed as 5323:a837d40687b9