583349 - Add a prompt to the input line in the Web Console

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: [checked-in] Proposed patch.

The input line provides no indication to the user of what it's for. This patch adds a prompt icon.

Because this is an important UI feature, I'd like to request blocking status for Firefox 4 betaN.

Comment 1

[David Dahl :ddahl]

Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

Looks good.r+++++. i like prompts. they make the world go round.

Comment 2

[Patrick Walton (:pcwalton)]

Attachment: Screenshot.

Screenshot attached.

Comment 3

[Dietrich Ayala (:dietrich)]

Doesn't block. Would approve a low-risk, well-tested patch.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

>diff --git a/toolkit/themes/pinstripe/global/icons/commandline.png b/toolkit/themes/pinstripe/global/icons/commandline.png

>diff --git a/toolkit/themes/pinstripe/global/jar.mn b/toolkit/themes/pinstripe/global/jar.mn

>+  skin/classic/global/icons/commandline.png                          (icons/commandline.png)

Given that this image appears to be the same across platforms, you could just use the ../../winstripe/ trick used earlier in this file to only have to add the file once.

r+a=me

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

http://hg.mozilla.org/mozilla-central/rev/d9ecbccfb8aa

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Please don't use pt. This isn't print.

Comment 7

[Rob Campbell [:rc] (:robcee)]

(In reply to comment #6)
> Please don't use pt. This isn't print.

If you have an issue with the code or functionality, please file a separate bug rather than griping in this one. Thanks.