Closed Bug 583349 Opened 10 years ago Closed 10 years ago

Add a prompt to the input line in the Web Console

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(blocking2.0 -)

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: pcwalton, Assigned: pcwalton)

References

Details

(Whiteboard: [kd4b4])

Attachments

(2 files)

The input line provides no indication to the user of what it's for. This patch adds a prompt icon.

Because this is an important UI feature, I'd like to request blocking status for Firefox 4 betaN.
Attachment #461666 - Flags: feedback?(ddahl)
Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

Looks good.r+++++. i like prompts. they make the world go round.
Attachment #461666 - Flags: feedback?(ddahl) → feedback+
Attachment #461666 - Flags: review?(gavin.sharp)
Attached image Screenshot.
Screenshot attached.
Doesn't block. Would approve a low-risk, well-tested patch.
blocking2.0: ? → -
Whiteboard: [kd4b4]
Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

>diff --git a/toolkit/themes/pinstripe/global/icons/commandline.png b/toolkit/themes/pinstripe/global/icons/commandline.png

>diff --git a/toolkit/themes/pinstripe/global/jar.mn b/toolkit/themes/pinstripe/global/jar.mn

>+  skin/classic/global/icons/commandline.png                          (icons/commandline.png)

Given that this image appears to be the same across platforms, you could just use the ../../winstripe/ trick used earlier in this file to only have to add the file once.

r+a=me
Attachment #461666 - Flags: review?(gavin.sharp)
Attachment #461666 - Flags: review+
Attachment #461666 - Flags: approval2.0+
Keywords: checkin-needed
Comment on attachment 461666 [details] [diff] [review]
[checked-in] Proposed patch.

http://hg.mozilla.org/mozilla-central/rev/d9ecbccfb8aa
Attachment #461666 - Attachment description: Proposed patch. → [checked-in] Proposed patch.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Please don't use pt. This isn't print.
(In reply to comment #6)
> Please don't use pt. This isn't print.

If you have an issue with the code or functionality, please file a separate bug rather than griping in this one. Thanks.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.