583356 - [10.5][Mac] No context menu available using Flash Version: 10.1.53.64 using Intel Mac, shows with PPC Mac

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Marcia Knous [:marcia]]

Bug 571135#c14 I noted that the context menu is not showing on Intel using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre.

STR:
1. Load youtube.com on an Intel Mac
2. Try to context click to bring up the Flash menu using Flash Version: 10.1.53.64
3. Nothing happens.

Perform the same set of STR using the same nightly build on a PPC mac and I see the context menu.

Comment 1

[Benjamin Smedberg]

WFM, 10.1.53.64 on MacOS 10.5 x86 using a recent nightly.

Comment 2

[Marcia Knous [:marcia]]

I see the following errors in the Console - my profile has no extensions installed.

7/30/10 2:51:27 PM [0x0-0x6d06d].org.mozilla.minefield 2010-07-30 14:51:27.360 firefox-bin[1225:10b] *** Assertion failure in +[NSEvent mouseEventWithType:location:modifierFlags:timestamp:windowNumber:context:eventNumber:clickCount:pressure:], /SourceCache/AppKit/AppKit-949.54/AppKit.subproj/NSEvent.m:305 
7/30/10 2:51:27 PM [0x0-0x6d06d].org.mozilla.minefield 2010-07-30 14:51:27.360 firefox-bin[1225:10b] Mozilla has caught an Obj-C exception [NSInternalInconsistencyException: Invalid parameter not satisfying: NSEventMaskFromType(type) & (MouseMask|NSMouseMovedMask)] 
7/30/10 2:51:27 PM [0x0-0x6d06d].org.mozilla.minefield 2010-07-30 14:51:27.589 firefox-bin[1225:10b] *** Assertion failure in +[NSEvent mouseEventWithType:location:modifierFlags:timestamp:windowNumber:context:eventNumber:clickCount:pressure:], /SourceCache/AppKit/AppKit-949.54/AppKit.subproj/NSEvent.m:305

Comment 3

[Benoit Girard (:BenWa)]

Reproducible on 10.6 with OOPP disabled since the error is coming from the in-process implementation of ContextMenu.

Error source:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsPluginUtilsOSX.mm#141

Comment 4

[Benoit Girard (:BenWa)]

The assertions are the same as Bug 561477.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Tentative Fix

Removing these 2 lines fixes the problem with me. Is there a reason why we don't want to always generated the menu using a right click event? It appears to be less error prone.

Comment 6

[Josh Aas]

Comment on attachment 462170 [details] [diff] [review]
Tentative Fix

I don't like it but I don't know how else to satisfy the requirements for "mouseEventWithType:...". Lets try it.

Comment 7

[Benoit Girard (:BenWa)]

Attachment: Added summary

Comment 8

[Benoit Girard (:BenWa)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/64fc10aefc50