583406 - Need notification for when Firefox version of Sync is outdated

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Came up in review of Sync UI since I removed the checks the extension performed. See bug 571897 comment 46 & 48

Comment 1

[Mike Connor [:mconnor]]

We need to get to a resolution on this very quickly, as it involves new UI/strings.  Fortunately, new-notifications landed, so we have room to play.

Comment 2

[Philipp von Weitershausen [:philikon]]

We still have the strings in services/sync from the addon:

error.sync.needUpdate.description = You need to update Firefox Sync to continue syncing your data.
error.sync.needUpdate.label = Update Firefox Sync
error.sync.needUpdate.accesskey = U

I think these are fine for the notification, we just want the button to do something different. In the add-on it opens the Addons Manager. In the integrated UI we might want it to open a page that explains that you want to install the Firefox Sync add-on to make your integrated Sync work again.

Comment 3

[Mike Connor [:mconnor]]

Yeah, that works.  It might be a "install this addon or this version of Firefox" answer, and that'll change in various ways with different contexts.  Can we get that in place, and point to a placeholder for now, and we'll sort out correct links later?

Comment 4

[Philipp von Weitershausen [:philikon]]

WFM!

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: screenshot

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 477966 [details] [diff] [review]
v1

I think this can be priority_info, actually.

Can we link to smc instead here?  This'll eventually be a SUMO link, like the other one, and putting something on mozilla.com as a placeholder feels wrong.

Comment 8

[Philipp von Weitershausen [:philikon]]

Attachment: v1.1 for check in

Changed URL to https://services.mozilla.com/update/

Comment 9

[Philipp von Weitershausen [:philikon]]

(In reply to comment #7)
> I think this can be priority_info, actually.

Forgot to address this comment...

This code is pretty much straight from the add-on (minus opening the Addon Manager). It also feels more than an info since it requires user interaction.

Comment 10

[Philipp von Weitershausen [:philikon]]

Attachment: v1.1 for check in

Bah, uploaded wrong file before. This has the new URL in it.

Comment 11

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/044c9998d47f

Comment 12

[Justin Fitzhugh]

also - isn't this not quite right when sync is native in firefox/fennec?  I.e. message should be "you need to update firefox to continue sync'ing"?  Seems we could have a link to a support article with more details also around storage versions...

Comment 13

[Mike Connor [:mconnor]]

We need to revisit strings here, the initial message is really hard because under some circumstances a user might install an add-on with a higher version than Firefox, which is why the important part is the more info link, since there's a few possibilities, all too complicated to explain in a one-line notification.

Comment 14

[Cameron Dawson [:camd]]

I'd like to verify this bug, however, I need to get the browser to think it's got an incompatible version with sync with the sync server.  Is there an about:config I can set to get it to think that?

Thanks!