7.19 KB, patch
|Details | Diff | Splinter Review|
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:22.214.171.124) Gecko/20100722 Firefox/3.6.8 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/20100722 Firefox/3.6.8 Updating from 188.8.131.52 to 184.108.40.206 the Java plugin now shows up under plugins despite having plugin.scan.SunJRE set to "99.0". Reproducible: Always Steps to Reproduce: 1.Set plugin.scan.SunJRE to a high value like 99.0 2.Install Java 220.127.116.11 3. Actual Results: The Java plugin is being listed. Expected Results: Java plugin should not be listed under plugins. I am seeing the same thing with Thunderbird/3.1.1 Gecko/20100713 but it should affect all builds of Firefox and Thunderbird using said Java version.
Oracle changed the vendor strings with 18.104.22.168.21 from Sun to Oracle http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6969236
Fixed for me with rv:22.214.171.124 Gecko/20100824 Firefox/3.6.9.
wfm without a patch
And the problem is back with the latest Java 126.96.36.199
Should setting plugin.scan.SunJRE to "99.0" through about:config then restarting be enough to reproduce? If so, I can reproduce with a SeaMonkey 2.10a1(pre) build.
We should remove support for this preference. All the current+secure versions of Java put their registry keys correctly into HKLM/Software/MozillaPlugins.
Created attachment 714757 [details] [diff] [review] Remove plugin.scan.SunJRE pref and associated code Hi, I was familiarising myself with Mercurial and patches, and I thought I would try and fix this bug... Sorry if the patch doesn't so the correct thing...
Comment on attachment 714757 [details] [diff] [review] Remove plugin.scan.SunJRE pref and associated code This look perfect. Normally you'd set the "review" "?" "revieweremail" flag, but since I'm the correct reviewer I'll just mark it. I don't think a try run will test anything useful since we don't have tests for out-of-data Java. Can you upload a final patch for checkin that includes a slightly better commit message (one mentioning Java at least) and includes "r=bsmedberg". After you've done that, add the 'checkin-needed' keyword to the bug.
Created attachment 714860 [details] [diff] [review] Remove old Java plugin scanning pref and related code Updated patch with better commit message
Comment on attachment 714860 [details] [diff] [review] Remove old Java plugin scanning pref and related code You don't need to request another review on this.
Ok, sorry about that...
(In reply to cykesiopka from comment #12) > Ok, sorry about that... No need to apologise - just something to know for the future. Thanks for the patch.