Closed
Bug 583629
Opened 15 years ago
Closed 15 years ago
Manifest from services/* are missing from package-manifest
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(blocking2.0 beta3+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta3+ |
People
(Reporter: zpao, Assigned: zpao)
References
Details
Attachments
(1 file)
960 bytes,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
Builds work ok but xpcshell tests failed on try
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
FYI - this does block beta3 (it blocks a beta blocker) but I don't have the magic powers needed to flip that switch. So just treat it as such.
Component: General → Build Config
Product: Core → Firefox
QA Contact: general → build.config
Updated•15 years ago
|
blocking2.0: --- → beta3+
Comment 3•15 years ago
|
||
Comment on attachment 461930 [details] [diff] [review]
Patch v0.1
Hmpf, not really sure why WeaveCrypto's in a separate manifest instead of being part of SyncComponents.manifest, but no harm.
Attachment #461930 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> Comment on attachment 461930 [details] [diff] [review]
> Patch v0.1
>
> Hmpf, not really sure why WeaveCrypto's in a separate manifest instead of being
> part of SyncComponents.manifest, but no harm.
The components are separated in the src (services/crypto vs services/sync/) so that's my best guess as to why.
blocking2.0: beta3+ → ---
Updated•15 years ago
|
blocking2.0: --- → beta3+
Assignee | ||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•