regression: element.getAttribute("type") is null in FormAssistant

VERIFIED FIXED

Status

Fennec Graveyard
General
--
major
VERIFIED FIXED
8 years ago
6 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 462164 [details] [diff] [review]
patch

Steps to reproduce:
1. Open http://people.mozilla.com/~mbrubeck/test/form-background.html
2. Click on the text input field

Expected results: Form helper appears.
Actual results: Form helper does not appear.

This is a regression from bug 583238.

Note: This line will later be replaced with just |type: element.type| - see bug 583238 comment 1.
Attachment #462164 - Flags: review?(webapps)
Comment on attachment 462164 [details] [diff] [review]
patch

Bah. I always forget if getAttribute returns null or ""
Attachment #462164 - Flags: review?(webapps) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mobile-browser/rev/e72cdeaec920
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110919
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.