Closed
Bug 583885
Opened 14 years ago
Closed 14 years ago
Fix FUEL browser_Bookmarks.js to not make bad assumption about annotations
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b3
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
This test assumes that, at a certain point, there will be 4 annotations on a bookmark and that the 2nd one will be a specific value. The Weave landing breaks this test, because bookmarks get a GUID at the 2nd position, increasing the count to 5 annotations. The simple fix for this test is to just have it ensure the values it expects are present, without relying on order.
Attachment #462221 -
Flags: review?(sdwilsh)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 462221 [details] [diff] [review] Patch v.1 r=sdwilsh for lolz
Attachment #462221 -
Flags: review?(sdwilsh) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/5cb477935096
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•