testDisabledElements.js uses newly deprecated function

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: ahal, Assigned: aaronmt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed by bug 584575])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
A change which rolls 'assertPropertyNotExist()' into 'assertNotProperty()' was just checked into Mozmill 1.4.2.

testPrivateBrowsing/testDisabledElements.js was the only test that used this function.

To fix: s/assertPropertyNotExist/assertNotProperty/

Note that the old function wasn't removed for 1.4.2, so tests that use it will still work, but will see a deprecation warning in the logs.
(Reporter)

Updated

8 years ago
See Also: → bug 583773
(Reporter)

Updated

8 years ago
Depends on: 583773
Aaron, could you update the test accordingly?
(Assignee)

Comment 2

8 years ago
Created attachment 462378 [details] [diff] [review]
Patch v1 - assertNotProperty

s/assertPropertyNotExist/assertNotProperty/
Attachment #462378 - Flags: review?(hskupin)
(Assignee)

Updated

8 years ago
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Comment on attachment 462378 [details] [diff] [review]
Patch v1 - assertNotProperty

Remind me to check this in once Mozmill 1.4.2 has been released.
Attachment #462378 - Flags: review?(hskupin) → review+
Whiteboard: [needs landing]
(Reporter)

Comment 4

8 years ago
As per the discussion in our weekly meeting this should be changed to either assertNotDOMProperty or assertNotJSProperty instead.
Aaron, can you please do that change and also create a new bug for moving all of our assertJS function calls which check attributes on nodes to assertNotJSProperty/assertJSProperty? Thanks.
Attachment #462378 - Attachment is obsolete: true
(Assignee)

Comment 6

8 years ago
Created attachment 463336 [details] [diff] [review]
Patch - assertNotDOMProperty

s/assertNotProperty/assertNotDOMProperty

I've never seen this function before so I'm assuming it's the same parameters and usage.
Attachment #463336 - Flags: review?(hskupin)
(Assignee)

Comment 7

8 years ago
(In reply to comment #5)
> Aaron, can you please do that change and also create a new bug for moving all
> of our assertJS function calls which check attributes on nodes to
> assertNotJSProperty/assertJSProperty? Thanks.

Can you please explain what assertNotJSProperty is, and an example of where you are looking to use it.
Comment on attachment 463336 [details] [diff] [review]
Patch - assertNotDOMProperty

>-  controller.assertPropertyNotExist(importHTML, "disabled");
>+  controller.assertNotDOMProperty(importHTML, "disabled");

assertProperty has been replaced by assertJSProperty which directly checks for the property of the given JS object. AssertDOMProperty will check the DOM attribute instead. That said the above code should use assertNotJSProperty.
Attachment #463336 - Flags: review?(hskupin) → review-
Whiteboard: [needs landing]
(Assignee)

Comment 9

8 years ago
Created attachment 464865 [details] [diff] [review]
Patch - Deprecation fixes on assert methods

Hopefully I got this right. Apologize, was confused with the name changes and adjusting to the different names, it wasn't clear at first.
Attachment #464865 - Flags: review?(hskupin)
Attachment #464865 - Flags: review?(hskupin) → review+
Whiteboard: [needs landing][not before Mozmill 1.4.2]
Fixed by bug 584575.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Depends on: 584575
Resolution: --- → FIXED
Whiteboard: [needs landing][not before Mozmill 1.4.2] → [fixed by bug 584575]
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Tests
Product: Testing → Mozilla QA
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.