Closed Bug 584575 Opened 14 years ago Closed 14 years ago

Update Mozmill tests to use assertJSProperty instead of assertProperty

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ahal, Assigned: aaronmt)

References

Details

Attachments

(3 files, 1 obsolete file)

As per the discussion in our weekly meetings and bug 583773 the controller API has been modified to differentiate asserting the JS and DOM properties of an element. Tests using assertProperty should be modified to use either assertJSProperty or assertDOMProperty (with the same parameters). A list of such tests can be found here: http://mxr.mozilla.org/mozilla-central/search?string=controller.assertProperty Note these tests will still run to completion, but will throw a deprecation error.
Depends on: 583773
(In reply to comment #0) > Tests using assertProperty should be modified to use either assertJSProperty or > assertDOMProperty (with the same parameters). A list of such tests can be Well it's assertJSProperty or assertDOMProperty but not both. We haven't had a change to check for element.getAttribute(...) so far. I'm still mixed-up which function to use but this bug covers assertProperty() to assertJSProperty, right? If that's the case the other bug we have file should be for existing assertJS calls to assertDOMProperty.
Aaron, this is more a search and replace patch. Could you have a look at?
Summary: Tests using controller.assertProperty will show a deprecation error in Mozmill 1.4.2 → Update Mozmill tests to use assertJSProperty instead of assertProperty
(In reply to comment #1) > If that's the case the other bug we have file should be for existing assertJS > calls to assertDOMProperty. There was none filed yet. We cover that work on bug 586286.
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
As mentioned, I'll do the swap after 1.4.2 release.
Attached patch Patch v1 - (default) (obsolete) — Splinter Review
Basically a search and replace s/assertProperty/assertJSProperty, 20 tests about 51 replacements
Attachment #468684 - Flags: review?(gmealer)
Aaron, as what I have said, it's nothing we want to do immediately. We will have to wait with that patch until we use Mozmill 1.5 on our lab boxes.
(In reply to comment #6) > Aaron, as what I have said, it's nothing we want to do immediately. We will > have to wait with that patch until we use Mozmill 1.5 on our lab boxes. Yep, just doing it now instead of later
Well, the patch will get bitrotted with our work for local test pages. So it's not really helpful and you will have to do it again.
No longer blocks: 585086
Patch still applies fine if you wish to review it now, Geo
Comment on attachment 468684 [details] [diff] [review] Patch v1 - (default) This patch fails to apply due to the latest local data check-ins. Can you please provide an updated version?
Attachment #468684 - Flags: review?(gmealer) → review-
Attachment #468684 - Attachment is obsolete: true
Attachment #478704 - Flags: review?(hskupin)
Comment on attachment 478704 [details] [diff] [review] Patch v2 - (default) Looks good. You have only missed the assertPropertyNotExist => assertNotJSProperty() change in testDisabledElements.js under private browsing. I will update before the check-in. Once it has landed please follow-up with backports as necessary.
Attachment #478704 - Flags: review?(hskupin) → review+
backport patch 1.9.2
Attachment #478764 - Flags: review?(hskupin)
backport patch 1.9.1
Attachment #478765 - Flags: review?(hskupin)
Attachment #478764 - Flags: review?(hskupin) → review+
Attachment #478765 - Flags: review?(hskupin) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Version: Trunk → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: