584575 - Update Mozmill tests to use assertJSProperty instead of assertProperty

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Andrew Halberstadt [:ahal]]

As per the discussion in our weekly meetings and bug 583773 the controller API has been modified to differentiate asserting the JS and DOM properties of an element.

Tests using assertProperty should be modified to use either assertJSProperty or assertDOMProperty (with the same parameters).  A list of such tests can be found here: http://mxr.mozilla.org/mozilla-central/search?string=controller.assertProperty

Note these tests will still run to completion, but will throw a deprecation error.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #0)
> Tests using assertProperty should be modified to use either assertJSProperty or
> assertDOMProperty (with the same parameters).  A list of such tests can be

Well it's assertJSProperty or assertDOMProperty but not both. We haven't had a change to check for element.getAttribute(...) so far. I'm still mixed-up which function to use but this bug covers assertProperty() to assertJSProperty, right?

If that's the case the other bug we have file should be for existing assertJS calls to assertDOMProperty.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aaron, this is more a search and replace patch. Could you have a look at?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> If that's the case the other bug we have file should be for existing assertJS
> calls to assertDOMProperty.

There was none filed yet. We cover that work on bug 586286.

Comment 4

[Aaron Train [:aaronmt]]

As mentioned, I'll do the swap after 1.4.2 release.

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

Basically a search and replace s/assertProperty/assertJSProperty, 20 tests about 51 replacements

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Aaron, as what I have said, it's nothing we want to do immediately. We will have to wait with that patch until we use Mozmill 1.5 on our lab boxes.

Comment 7

[Aaron Train [:aaronmt]]

(In reply to comment #6)
> Aaron, as what I have said, it's nothing we want to do immediately. We will
> have to wait with that patch until we use Mozmill 1.5 on our lab boxes.

Yep, just doing it now instead of later

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, the patch will get bitrotted with our work for local test pages. So it's not really helpful and you will have to do it again.

Comment 9

[Aaron Train [:aaronmt]]

Patch still applies fine if you wish to review it now, Geo

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 468684 [details] [diff] [review]
Patch v1 - (default)

This patch fails to apply due to the latest local data check-ins. Can you please provide an updated version?

Comment 11

[Aaron Train [:aaronmt]]

Attachment: Patch v2 - (default)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 478704 [details] [diff] [review]
Patch v2 - (default)

Looks good. You have only missed the assertPropertyNotExist => assertNotJSProperty() change in testDisabledElements.js under private browsing. I will update before the check-in. Once it has landed please follow-up with backports as necessary.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/b1281cf0c54d

Comment 14

[Aaron Train [:aaronmt]]

Attachment: Patch v2 - (1.9.2)

backport patch 1.9.2

Comment 15

[Aaron Train [:aaronmt]]

Attachment: Patch v2 - (1.9.1)

backport patch 1.9.1

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Backports landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/a051a295b3f2 (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/307ef5d1c5c6 (mozilla1.9.1)

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.