584001 - mozilla-central pushlog on hg.mozilla.org is broken

Status: VERIFIED FIXED

(mozilla.org Graveyard :: Server Operations, task, P1)

Description

[Justin Dolske [:Dolske]]

Attachment: hg fail

Went to push a backout, forgot to have "CLOSED TREE" in the message, fixed my commit, pushed again, and now it fails with "remote: error: pretxnchangegroup.z_loghistory hook raised an exception: column rev is not unique"

This needs fixed asap, since we're freezing for Beta 3.

Comment 1

[Axel Hecht [:Pike]]

json-pushes shows

 }, 
 "14813": {
  "date": 1280828630, 
  "changesets": [
   "898c7378890d6815da9c370ae9a1876e8c88c092"
  ], 
  "user": "[e-mail]"

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Need to manually removing the relevant commit (898c7378890d6815da9c370ae9a1876e8c88c092) from the pushlog DB (as in bug 583613, bug 573264).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(and then clear the pushlog cache, ideally)

Comment 4

[Jeremy Orem [:oremj]]

Not sure how to do this. I've paged Aravind.

Comment 5

[Justin Dolske [:Dolske]]

Just in case it help prevent this from ever, ever, happening again, here's my shell history for what I did:

  649  hg push
  650  hg outgoing
  651  hg qimport -r 48785
  652  hg qseries
  653  hg qpop
  654  hg pull -u
  655  hg up -r default
  656  hg qpush
  657  hg outgoing -p
  658  hg qrefresh -e
  659  hg qfinish -a
  660  hg outgoing
  661  hg push

649 was the push that failed because I didn't have "CLOSED TREE" in my message, the rest are me updating my repo, and 661 is the push that broke as the attachment shows.

Comment 6

[Axel Hecht [:Pike]]

me mumbles something about "varnish cache, too".

Did I ever write down what I had in mind on how to fix our hook ordering to get them back into pretxn? Because I don't remember :-(

Comment 7

[Justin Dolske [:Dolske]]

I am going to go to sleep now so I can attempt to resume my beta 3 work in a better-than-zombielike-state tomorrow.

Once Hg is working again, two things should be done:

1) Land the backout of attachment 461660 [details] [diff] [review] from bug 583339. It's what I was trying to land when Hg broke, and is just a 1-line change.

2) Trigger a new round of nightly builds. nthomas killed the usual nightlies because we wanted to wait for this backout.

Comment 8

[Aravind Gottipati [:aravind]]

Sorry, I slept through the first page.  Am here now, clearing pushlog and the cache.  Will comment here when its all good to go.

Comment 9

[Aravind Gottipati [:aravind]]

Deleted the rev, and cleared cache.  We should be able to push to m-c now.

fwiw, I was working on this yesterday and submitted a patch to the mercurial devs.  Hopefully, it's all good and I will patch our mercurial setup today.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Thanks, worked. Sorry for the wakeup :(